Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added alerting-dashboard-plugin to manifest 1.2.0. #874

Closed
wants to merge 7 commits into from

Conversation

AWSHurneyt
Copy link
Contributor

Description

Adding alerting-dashboard-plugin to manifest 1.2.0.

Issues Resolved

issue118

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dblock
Copy link
Member

dblock commented Nov 3, 2021

Rebase this on top of #876, I think this is an unrelated failure.

Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This YAML is invalid, so tests are failing as expected.

@codecov-commenter
Copy link

codecov-commenter commented Nov 3, 2021

Codecov Report

Merging #874 (ad0cd46) into main (60a2962) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #874   +/-   ##
=======================================
  Coverage   91.21%   91.21%           
=======================================
  Files          88       88           
  Lines        2379     2379           
=======================================
  Hits         2170     2170           
  Misses        209      209           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60a2962...ad0cd46. Read the comment docs.

…1.2release' into 1.2release

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
@AWSHurneyt
Copy link
Contributor Author

Closing this PR in favor of PR 886.

@AWSHurneyt AWSHurneyt closed this Nov 4, 2021
@AWSHurneyt AWSHurneyt deleted the 1.2release branch November 5, 2021 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants