Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add security dashdoards plugin to manifest 1.2.0 #866

Conversation

hsiang9431-amzn
Copy link
Contributor

@hsiang9431-amzn hsiang9431-amzn commented Nov 2, 2021

Description

[Describe what this change achieves]

Issues Resolved

[List any issues this PR will resolve]

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov-commenter
Copy link

codecov-commenter commented Nov 2, 2021

Codecov Report

Merging #866 (6316dfc) into main (d6a3292) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #866   +/-   ##
=======================================
  Coverage   91.22%   91.22%           
=======================================
  Files          88       88           
  Lines        2382     2382           
=======================================
  Hits         2173     2173           
  Misses        209      209           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6a3292...6316dfc. Read the comment docs.

@peternied
Copy link
Member

Looks like this is impacted by a failure from asynchronous-search, #864 @zelinh Can you rollback that change so this PR isn't blocked?

@zelinh
Copy link
Member

zelinh commented Nov 2, 2021

Looks like this is impacted by a failure from asynchronous-search, #864 @zelinh Can you rollback that change so this PR isn't blocked?

I think this one is for the dashboard and #864 was for bundle-build.

@hsiang9431-amzn
Copy link
Contributor Author

This PR is for adding security dashboards to manifest, thanks for investigating

@dblock
Copy link
Member

dblock commented Nov 3, 2021

Rebase this on top of #876, I think this is an unrelated failure.

Signed-off-by: Jason <hsiang@amazon.com>
@peternied peternied merged commit 09c8c0a into opensearch-project:main Nov 3, 2021
@hsiang9431-amzn hsiang9431-amzn deleted the add-security-front-end-plugin branch November 4, 2021 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants