-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Future proof install scripts by passing platform and architecture through. #831
Future proof install scripts by passing platform and architecture through. #831
Conversation
…ough. Signed-off-by: dblock <dblock@amazon.com>
@dblock With opensearch-project/opensearch-plugins#91, eventually all plugin artifacts should have the same layout based on the standard and they should be able to use the same install script. That being said, does it make sense to move install scripts out of this repo at the time being, given that when it is standardized, only one install script will be needed for all plugins? I was looking into why install script_finder does not look in Git repos for scripts and the reason seems to be that build takes a dependency on the components' git repo to build the artifacts, while assemble takes a dependency on the artifacts. I do not believe it will be a trivial change to add components' git repos as dependencies for assemble workflow. |
Oh you're absolutely right, now I remember. I am OK if you just hack this install script with some Or, we could maybe build something slightly more generic? What if build produced an "install" folder along with "libs", "dist", "maven", etc.? Then copy everything from "install" into the distribution as default post-install? |
What would be in the install folder and why would it need to be in the distribution? |
|
I do think we should still merge this as it aligns the arguments between build and install scripts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets move forward, we can always revert/rewrite if we come up with a better solution
Signed-off-by: dblock dblock@amazon.com
Description
Change the arguments for install scripts to include platform and architecture
before we spread them in repos.Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.