Future proof install scripts by passing platform and architecture through.

[dblock]

Signed-off-by: dblock dblock@amazon.com

Description

Change the arguments for install scripts to include platform and architecture before we spread them in repos.

Check List

• Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[dblock]

@jmazanec15

[jmazanec15]

@dblock With opensearch-project/opensearch-plugins#91, eventually all plugin artifacts should have the same layout based on the standard and they should be able to use the same install script. That being said, does it make sense to move install scripts out of this repo at the time being, given that when it is standardized, only one install script will be needed for all plugins?

I was looking into why install script_finder does not look in Git repos for scripts and the reason seems to be that build takes a dependency on the components' git repo to build the artifacts, while assemble takes a dependency on the artifacts. I do not believe it will be a trivial change to add components' git repos as dependencies for assemble workflow.

[dblock]

I was looking into why install script_finder does not look in Git repos for scripts and the reason seems to be that build takes a dependency on the components' git repo to build the artifacts, while assemble takes a dependency on the artifacts. I do not believe it will be a trivial change to add components' git repos as dependencies for assemble workflow.

Oh you're absolutely right, now I remember.

I am OK if you just hack this install script with some if statements or whatever you want to do to work around the problem for now.

Or, we could maybe build something slightly more generic? What if build produced an "install" folder along with "libs", "dist", "maven", etc.? Then copy everything from "install" into the distribution as default post-install?

[jmazanec15]

Then copy everything from "install" into the distribution as default post-install?

What would be in the install folder and why would it need to be in the distribution?

[dblock]

Then copy everything from "install" into the distribution as default post-install?

What would be in the install folder and why would it need to be in the distribution?

1. k-nn now places libs/libknn.so into plugins/opensearch-knn/knnlib -> k-nn builds install/plugins/opensearch-knn/knnlib/libknn.so
2. build places scripts/legacy/tar/linux/opensearch-tar-install.sh as post-install, instead it could include it as post-build of OpenSearch and place it into install/opensearch-install.sh for *nix and install\opensearch-install.bat for windows.

[dblock]

I do think we should still merge this as it aligns the arguments between build and install scripts.

[peternied]

Lets move forward, we can always revert/rewrite if we come up with a better solution