Removes check to validate presence of OPENSEARCH_INITIAL_ADMIN_PASSWORD variable from preinst script of DEB distribution
#4453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f DEB distribution Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
DarshitChanpura
requested review from
dblock,
peterzhuamazon,
bbarani,
gaiksaya,
rishabh6788,
zelinh,
jordarlu,
prudhvigodithi,
Divyaasm and
tianleh
as code owners
DarshitChanpura
changed the title
OPENSEARCH_INITIAL_ADMIN_PASSWORD variable from preinst script of DEB distribution
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4453 +/- ##
=======================================
Coverage 91.55% 91.55%
=======================================
Files 190 190
Lines 6214 6214
=======================================
Hits 5689 5689
Misses 525 525 ☔ View full report in Codecov by Sentry. |
88 tasks
bbarani
approved these changes
Feb 14, 2024
prudhvigodithi
approved these changes
Feb 14, 2024
peterzhuamazon
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While testing 2.12 RC it was discovered that the current check to validate whether
OPENSEARCH_INITIAL_ADMIN_PASSWORDenv variable is defined, is flawed and doesn't work always. There were other options considered as well but none satisfy a uniform experience for preinstall script :dpkg-query -W opensearch(current): Prematurely evaluates to true as soon as install startsdpkg -l opensearch: Works only in upgrade scenarios. For fresh installationpreinstdoesn't break (which is what is expected). Prematurely evaluates to true as soon as install starts.dpkg-query -s opensearch | grep -i ("Status: install ok installed"): fails on upgrade (it shouldn't), works fine for fresh installationHence, this PR removes changes from preinstall script for DEB distribution.
Note: RPM is not affected.
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.