feat: remove useless config

[SuZhou-Joe]

Description

• Chatbot and Agent framework changed the implementation of how to retrieve the root agent, so the rootAgentName config is useless, remove that from config and template.
• The root agent is config in a ml system index, and it prevents FTRepo to set agent id into the index when running Cypress test(system index config can only be changed in opensearch.yml file), so move the security test out of the test manifest.

The dashboards-assistant plugin is an experimental plugin and we will address the security test in 2.13.

Issues Resolved

List any issues this PR will resolve, e.g. Closes [...].

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ec71ce6) 91.35% compared to head (13f7b79) 91.35%.
Report is 4 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #4402   +/-   ##
=======================================
  Coverage   91.35%   91.35%           
=======================================
  Files         190      190           
  Lines        6197     6197           
=======================================
  Hits         5661     5661           
  Misses        536      536           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[gaobinlong]

LGTM.

[peterzhuamazon]

Even after reading the description I dont get why are we removing the security test. Could you elaborate?

Thanks.

[SuZhou-Joe]

assistantDashboards requires a config in system index, but we can not put doc into that index in our cypress test workflow as it requires the security .pem file to do so.

[SuZhou-Joe]

If we want to do test against a Chatbot root agent, we have to set the config inside the system index. However when security enabled, we can not do that inside Cypress test as system_index setting is a static setting that can only be modified in the opensearch.yml file.

[gaiksaya]

So you mean in order to support tests with security you need additional config to be added to opensearch.yml?

[SuZhou-Joe]

Yes, that should work too.

[gaiksaya]

Looks like a feature request. AFAIK additional-cluster-configs only supports the product under test (OpenSearch or Dashboards. Not both)
https://github.com/search?q=repo%3Aopensearch-project%2Fopensearch-build+additional-cluster-configs&type=code&p=1

@peterzhuamazon Looks like time to open this issue #3589 :)

[peterzhuamazon]

Have sync up with @SuZhou-Joe and it seems we either implement #3589, which we dont have much time for 2.12, or remove the feature after @SuZhou-Joe discuss with @ylwu-amzn.

There is another option which is to comment out the - with-security and list it a TODO to be fixed in the next release.

[SuZhou-Joe]

@bbarani @prudhvigodithi Could you please take a look here?

[peterzhuamazon]

Restore security test due to this:

• opensearch-project/opensearch-dashboards-functional-test@2f5d2f0