Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the variable name for issue creation #4385

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

gaiksaya
Copy link
Member

Description

Fix the variable name for issue creation. Due to groovy-truth the non-empty strings are interpreted as true https://docs.groovy-lang.org/latest/html/documentation/core-semantics.html#_strings

Issues Resolved

List any issues this PR will resolve, e.g. Closes [...].

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>
Copy link

codecov bot commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (413a619) 91.35% compared to head (1544d96) 91.35%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4385   +/-   ##
=======================================
  Coverage   91.35%   91.35%           
=======================================
  Files         190      190           
  Lines        6197     6197           
=======================================
  Hits         5661     5661           
  Misses        536      536           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gaiksaya gaiksaya merged commit bee34c6 into opensearch-project:main Jan 30, 2024
13 checks passed
@gaiksaya gaiksaya deleted the fix-boolean branch January 30, 2024 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants