Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin ITs manifest with concurrent segment search enabled on OS-2.x #4283

Merged
merged 2 commits into from
Dec 19, 2023

Conversation

sohami
Copy link
Contributor

@sohami sohami commented Dec 13, 2023

Description

Adding the manifest file for concurrent segment search with the respective settings needed to enable the feature for 2.12.0

Issues Resolved

N/A

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@sohami
Copy link
Contributor Author

sohami commented Dec 13, 2023

@prudhvigodithi @rishabh6788 - Can you please help review it ? Also will need help to enable the cron for this. I think @gaiksaya helped to make that change last time.

Copy link

codecov bot commented Dec 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5ac4089) 91.26% compared to head (6008382) 91.26%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4283   +/-   ##
=======================================
  Coverage   91.26%   91.26%           
=======================================
  Files         189      189           
  Lines        6124     6124           
=======================================
  Hits         5589     5589           
  Misses        535      535           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@prudhvigodithi
Copy link
Member

Hey @sohami, please check this https://github.com/opensearch-project/opensearch-build/blob/main/jenkins/check-for-build.jenkinsfile#L28, you can add a new line similar to this and point to 2.12.0/opensearch-2.12.0-concurrent-search-test.yml

@gaiksaya
Copy link
Member

Hey @sohami, please check this https://github.com/opensearch-project/opensearch-build/blob/main/jenkins/check-for-build.jenkinsfile#L28, you can add a new line similar to this and point to 2.12.0/opensearch-2.12.0-concurrent-search-test.yml

That will re-trigger the build @prudhvigodithi or skip since check for build wont pass through detecting no changes have been made to any component. Last time we added it as a cronjob to the integ-test file here: https://github.com/opensearch-project/opensearch-build/blob/main/jenkins/opensearch/integ-test.jenkinsfile

Sorabh Hamirwasia added 2 commits December 19, 2023 11:34
Signed-off-by: Sorabh Hamirwasia <hsorabh@amazon.com>
Signed-off-by: Sorabh Hamirwasia <hsorabh@amazon.com>
@sohami
Copy link
Contributor Author

sohami commented Dec 19, 2023

Thanks @gaiksaya for your help. Have added the cron related info in the jenkins file

@gaiksaya gaiksaya merged commit a13aa1c into opensearch-project:main Dec 19, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants