-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Central workflow to trigger pre-release workflows #4280
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4280 +/- ##
==========================================
- Coverage 91.26% 91.18% -0.09%
==========================================
Files 189 189
Lines 6124 6146 +22
==========================================
+ Hits 5589 5604 +15
- Misses 535 542 +7 ☔ View full report in Codecov by Sentry. |
Some high level details.
|
7d974fb
to
08453a1
Compare
dfe578a
to
734c34d
Compare
FYI, Found that the Jenkins tests has a bug handling Seen this in past PR as well. I have raised a comment in JenkinsPipelineUnit repo regarding this jenkinsci/JenkinsPipelineUnit#551 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some minor nits with naming. I would suggest to replace all echo statements with actually artifact promotion statments. For example, as an external user I don't know what promote-repos jobs does. So echo statement at the end of execution can help them understand, yum repo for opensearch-2.12.0 is release successfully
.
ed1befa
to
16efa55
Compare
Hey @gaiksaya I have updated all your NIT's in my latest commit, coming back with your suggestion to update the echo statement as |
Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com>
Description
Part of pre-release actives, a central workflow that triggers all the pre-release workflows.
Issues Resolved
#4136 (comment)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.