-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding support to run integration tests in Jenkins #423
Adding support to run integration tests in Jenkins #423
Conversation
Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>
Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>
Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #423 +/- ##
==========================================
+ Coverage 64.82% 65.54% +0.71%
==========================================
Files 48 47 -1
Lines 1288 1274 -14
==========================================
Hits 835 835
+ Misses 453 439 -14
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- It might not be possible, but a bundle defines the architecture for which it's built. This job lets me try and run a bundle for x86 on arm, which is not desirable. Can this be loaded from the bundle?
- I'm worried that we're introducing
test_integration.sh
, which we have agreed to really betest.sh --suite integration
or something like that. Can we do this, even if it's super hacky insidetest.sh
, in this PR so we don't have to go change it all over the place?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was expecting to see all the legs of the integration tests executed, integration
, bwc
, perf
is that coming in a future PR?
Sure. This is a middle piece i.e bundle workflow -> test orchestrator -> individual test job. |
|
@saratvemulapalli During our discussion yesterday reading the manifest for architecture and reducing number of input parameters were mentioned - I'm waiting on those change |
… integtest Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>
Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>
Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>
Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>
Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>
bundle-workflow/README.md
Outdated
```bash | ||
./bundle-workflow/test.sh manifests/opensearch-1.1.0.yml | ||
./bundle-workflow/test.sh integ-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which manifest?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if the question was what manifest do we use for integ tests. If it is, it uses build and bundle manifest and it fetches it by itself.
I would like to have #456 update this readme to add the rest of the new parameters to this readme.
Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>
Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @saratvemulapalli
@@ -9,4 +9,4 @@ | |||
set -e | |||
|
|||
DIR="$(dirname "$0")" | |||
"$DIR/run.sh" "$DIR/src/test.py" $@ | |||
"$DIR/run.sh" "$DIR/src/test.py" $@ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you delete src/test.py?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, @setiah will add the test.sh in #456 as part of his PR.
Ref: #423 (comment)
Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>
Description
Adding support to run integration tests in Jenkins.
Parameters Integration Tests need:
Issues Resolved
Closes #263
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.