Add hybrid search enable param support to neuralsearch integTest #3927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
peterzhuamazon
added
enhancement
peterzhuamazon
requested review from
dblock,
bbarani,
gaiksaya,
rishabh6788,
zelinh,
jordarlu,
prudhvigodithi,
Divyaasm and
tianleh
as code owners
|
Please keep this open without merge until v2.10.0 is coming, so that @martin-gaievski team can push their hybrid changes before this is merged. Thanks. |
Codecov Report
@@ Coverage Diff @@
## main #3927 +/- ##
=======================================
Coverage 92.05% 92.05%
=======================================
Files 187 187
Lines 5667 5667
=======================================
Hits 5217 5217
Misses 450 450 |
42 tasks
|
Corresponding change has been merged to neural-search plugin repo, please merge this PR to enable feature and avoid failures in distribution integration tests @peterzhuamazon |
jordarlu
approved these changes
Aug 28, 2023
71 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add hybrid search enable param support to neuralsearch integTest
Issues Resolved
#3743
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.