Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve securityDashboards not correctly removed on DEB/RPM #3525

Conversation

peterzhuamazon
Copy link
Member

@peterzhuamazon peterzhuamazon commented May 17, 2023

Description

Resolve securityDashboards not correctly removed on DEB/RPM.
If sudo is not applied to DEB/RPM plugin removal, the run will still goes to success and return 0, despite the plugin directory is still there.

Issues Resolved

#3331

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
@peterzhuamazon
Copy link
Member Author

peterzhuamazon commented May 17, 2023

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
@codecov
Copy link

codecov bot commented May 17, 2023

Codecov Report

Merging #3525 (747f359) into main (65b1b6d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #3525   +/-   ##
=======================================
  Coverage   91.16%   91.16%           
=======================================
  Files         181      181           
  Lines        5340     5342    +2     
=======================================
+ Hits         4868     4870    +2     
  Misses        472      472           
Impacted Files Coverage Δ
...rkflow/integ_test/service_opensearch_dashboards.py 96.77% <100.00%> (+0.10%) ⬆️

@peterzhuamazon peterzhuamazon merged commit 12eeba7 into opensearch-project:main May 17, 2023
@peterzhuamazon peterzhuamazon deleted the osd_integtest_remove_osd_security_plugin branch May 17, 2023 00:47
@peterzhuamazon
Copy link
Member Author

peterzhuamazon commented May 17, 2023

After this patch:

2023-05-17 00:27:24 INFO     | queryWorkbenchDashboards | with-security        | PASS  |
2023-05-17 00:27:24 INFO     | queryWorkbenchDashboards | without-security     | PASS  |

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

2 participants