-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Opensearch security plugin windows install certs demo config and add batch install script #2704
Opensearch security plugin windows install certs demo config and add batch install script #2704
Conversation
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Codecov Report
@@ Coverage Diff @@
## main #2704 +/- ##
=======================================
Coverage 94.10% 94.10%
=======================================
Files 156 156
Lines 4208 4208
=======================================
Hits 3960 3960
Misses 248 248 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Quoting DB from #2061
Work around looks good to me - please work with @scrawfor99 if you'd like help staging things between here and the security repository |
Hi, I would suggest you to check these categories within the build repo code base a bit more and it should help you understand the reasoning better. Here are some few points that might interest you. 1. Check script finder class on how the install.sh being allocated. 2. Check dist and bundle code within assemble workflow to understand why it cannot be saved in plugin repositories. Understand the differences between build.sh and install.sh and how are they being processed. Additionally if you have time available I would suggest you contribute the functionalities to call install.sh from separate repositories if you would like this feature to be added. Bare in mind, this is a heavy operation and as of current state it is not required to be used for the assemble workflow. Thanks. |
Sure will work with @scrawfor99 when needed. |
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Will force merge for now as the groovy test failure is not related to my code in this PR. Thanks. |
…batch install script (opensearch-project#2704) * Security script for install.sh add windows specific changes Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Add Windows install batch and resolve security plugin demo config issues Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Add more comments Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Add more comments Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Add more comments Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Add more comments Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Add sql 2.4.0 Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Add sql 2.4.0 Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Add comments Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Add comments Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Add comments Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> Signed-off-by: Monu Singh <msnghgw@amazon.com>
Description
Add windows batch file and resolve security demo config temporarily.
Follow up: opensearch-project/security#2148
Issues Resolved
opensearch-project/security#2122
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.