Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opensearch security plugin windows install certs demo config and add batch install script #2704

Conversation

peterzhuamazon
Copy link
Member

@peterzhuamazon peterzhuamazon commented Oct 6, 2022

Description

Add windows batch file and resolve security demo config temporarily.
Follow up: opensearch-project/security#2148

Issues Resolved

opensearch-project/security#2122

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
@peterzhuamazon peterzhuamazon added bug Something isn't working enhancement New Enhancement windows labels Oct 6, 2022
@peterzhuamazon peterzhuamazon self-assigned this Oct 6, 2022
@peterzhuamazon peterzhuamazon requested a review from a team as a code owner October 6, 2022 22:55
@peterzhuamazon peterzhuamazon changed the title Opensearch security windows install Opensearch security windows install certs demo config and add batch install script Oct 6, 2022
@peterzhuamazon peterzhuamazon changed the title Opensearch security windows install certs demo config and add batch install script Opensearch security plugin windows install certs demo config and add batch install script Oct 6, 2022
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
@codecov-commenter
Copy link

codecov-commenter commented Oct 6, 2022

Codecov Report

Merging #2704 (86e7304) into main (6b71a5f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2704   +/-   ##
=======================================
  Coverage   94.10%   94.10%           
=======================================
  Files         156      156           
  Lines        4208     4208           
=======================================
  Hits         3960     3960           
  Misses        248      248           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
@peternied
Copy link
Member

Quoting DB from #2061

Shouldn't you be committing this [scripts/components/security/install.sh] into the security plugin repo instead in the right branch?

Work around looks good to me - please work with @scrawfor99 if you'd like help staging things between here and the security repository

@peterzhuamazon
Copy link
Member Author

peterzhuamazon commented Oct 10, 2022

Quoting DB from #2061

Shouldn't you be committing this [scripts/components/security/install.sh] into the security plugin repo instead in the right branch?

Hi,
Glad you bring up this question. As this PR is a completely different situation compares to the PR you raised in #2061.

I would suggest you to check these categories within the build repo code base a bit more and it should help you understand the reasoning better. Here are some few points that might interest you.

1. Check script finder class on how the install.sh being allocated.
(Yes, install.sh will not be allocated from the component repo directly)

2. Check dist and bundle code within assemble workflow to understand why it cannot be saved in plugin repositories. Understand the differences between build.sh and install.sh and how are they being processed.
(Build requires all components to be cloned thus scripts can exist in separate repos, but install will allocate only the artifacts on the build machines without the need to allocate other repos, or it will be a heavy operation.)

Additionally if you have time available I would suggest you contribute the functionalities to call install.sh from separate repositories if you would like this feature to be added. Bare in mind, this is a heavy operation and as of current state it is not required to be used for the assemble workflow.

Thanks.

@peterzhuamazon
Copy link
Member Author

Work around looks good to me - please work with @scrawfor99 if you'd like help staging things between here and the security repository

Sure will work with @scrawfor99 when needed.
Thanks.

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
@peterzhuamazon
Copy link
Member Author

Will force merge for now as the groovy test failure is not related to my code in this PR.
More information here: opensearch-project/opensearch-build-libraries#7 (comment)

Thanks.

@peterzhuamazon peterzhuamazon merged commit 1d84633 into opensearch-project:main Oct 10, 2022
@peterzhuamazon peterzhuamazon deleted the opensearch-security-windows-install branch October 10, 2022 21:34
monusingh-1 pushed a commit to monusingh-1/os_build that referenced this pull request Nov 2, 2022
…batch install script (opensearch-project#2704)

* Security script for install.sh add windows specific changes

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>

* Add Windows install batch and resolve security plugin demo config issues

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>

* Add more comments

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>

* Add more comments

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>

* Add more comments

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>

* Add more comments

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>

* Add sql 2.4.0

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>

* Add sql 2.4.0

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>

* Add comments

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>

* Add comments

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>

* Add comments

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Monu Singh <msnghgw@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New Enhancement windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants