Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added index-management and dashboard plugin to 2.3 manifest files #2593

Merged
merged 8 commits into from
Sep 8, 2022

Conversation

Angie-Zhang
Copy link
Contributor

Description

Added index-management and dashboard plugin to 2.3 manifest files

Issues Resolved

opensearch-project/index-management#481
opensearch-project/index-management-dashboards-plugin#242

Redirected from #2579

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Angie Zhang and others added 2 commits September 8, 2022 14:19
Signed-off-by: Angie Zhang <langelzh@amazon.com>
Signed-off-by: Angie Zhang <langelzh@amazon.com>
@Angie-Zhang Angie-Zhang requested a review from a team as a code owner September 8, 2022 21:23
@gaiksaya
Copy link
Member

gaiksaya commented Sep 8, 2022

Hey @Angie-Zhang looks like conflicts still exits. Can you solve this?
Thanks!

Signed-off-by: Angie Zhang <langelzh@amazon.com>
@codecov-commenter
Copy link

codecov-commenter commented Sep 8, 2022

Codecov Report

Merging #2593 (8b83ef9) into main (dbe41c2) will decrease coverage by 2.75%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #2593      +/-   ##
============================================
- Coverage     94.41%   91.66%   -2.76%     
  Complexity       28       28              
============================================
  Files           219       63     -156     
  Lines          4462      288    -4174     
  Branches         29       29              
============================================
- Hits           4213      264    -3949     
+ Misses          243       18     -225     
  Partials          6        6              
Impacted Files Coverage Δ
src/test_workflow/perf_test/perf_args.py
src/sign_workflow/sign_artifacts.py
src/assemble_workflow/bundle.py
src/ci_workflow/ci_check_lists.py
...workflow/ci_check_gradle_publish_to_maven_local.py
...w/bwc_test/bwc_test_start_properties_opensearch.py
src/system/temporary_directory.py
src/manifests_workflow/input_manifests.py
src/test_workflow/integ_test/distribution_tar.py
src/test_workflow/test_component.py
... and 146 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@@ -141,3 +141,10 @@ components:
checks:
- gradle:properties:version
- gradle:dependencies:opensearch.version: alerting
- name: index-management
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation issue :)

Angie Zhang added 3 commits September 8, 2022 14:43
# Conflicts:
#	manifests/2.3.0/opensearch-2.3.0.yml
Signed-off-by: Angie Zhang <langelzh@amazon.com>
Signed-off-by: Angie Zhang <langelzh@amazon.com>
@gaiksaya
Copy link
Member

gaiksaya commented Sep 8, 2022

Hi @Angie-Zhang I created another PR to move ahead #2594
Thanks!

Signed-off-by: Angie Zhang <langelzh@amazon.com>
@gaiksaya gaiksaya merged commit 20cb37f into opensearch-project:main Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants