Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add common-utils to 2.1.0 manifest and remove security plugin #2227

Merged
merged 2 commits into from
Jun 22, 2022

Conversation

sbcd90
Copy link
Contributor

@sbcd90 sbcd90 commented Jun 22, 2022

Signed-off-by: Subhobrata Dey sbcd90@gmail.com

Description

add common-utils to 2.1.0 manifest and remove security plugin

Issues Resolved

Release version 2.1.0

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Subhobrata Dey <sbcd90@gmail.com>
@sbcd90 sbcd90 requested a review from a team as a code owner June 22, 2022 22:12
@codecov-commenter
Copy link

codecov-commenter commented Jun 22, 2022

Codecov Report

Merging #2227 (d7f1bb5) into main (c46e1a1) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #2227   +/-   ##
=========================================
  Coverage     94.56%   94.56%           
  Complexity       25       25           
=========================================
  Files           205      205           
  Lines          4254     4254           
  Branches         29       29           
=========================================
  Hits           4023     4023           
  Misses          225      225           
  Partials          6        6           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c46e1a1...d7f1bb5. Read the comment docs.

@gaiksaya
Copy link
Member

Hi @sbcd90 Can you remove security plugin from this manifest? It was failing before so better to remove it. I'll add it later.
cc: @DarshitChanpura @cliu123

Signed-off-by: Subhobrata Dey <sbcd90@gmail.com>
@sbcd90
Copy link
Contributor Author

sbcd90 commented Jun 22, 2022

hi @gaiksaya , removed security plugin from manifest

@gaiksaya
Copy link
Member

Thank you. LGTM

@gaiksaya gaiksaya changed the title add common-utils to 2.1.0 manifest add common-utils to 2.1.0 manifest and remove security plugin Jun 22, 2022
@gaiksaya gaiksaya merged commit 5ffbbb9 into opensearch-project:main Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants