Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RPM Temporary Signing Through Shell Scripts #2196

Conversation

peterzhuamazon
Copy link
Member

Signed-off-by: Peter Zhu zhujiaxi@amazon.com

Description

Add RPM Temporary Signing Through Shell Scripts

Issues Resolved

Part of #2190

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
@codecov-commenter
Copy link

codecov-commenter commented Jun 15, 2022

Codecov Report

Merging #2196 (d88b188) into main (b19382e) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #2196   +/-   ##
=========================================
  Coverage     94.56%   94.56%           
  Complexity       25       25           
=========================================
  Files           204      204           
  Lines          4253     4253           
  Branches         29       29           
=========================================
  Hits           4022     4022           
  Misses          225      225           
  Partials          6        6           
Impacted Files Coverage Δ
tests/jenkins/jobs/SignArtifacts_Jenkinsfile 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b19382e...d88b188. Read the comment docs.

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Copy link
Member

@zelinh zelinh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve after offline discussion with @peterzhuamazon . Thanks.

@peterzhuamazon peterzhuamazon merged commit 950d55c into opensearch-project:main Jun 15, 2022
@peterzhuamazon peterzhuamazon deleted the opensearch-rpm-signing-temp branch June 15, 2022 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New Enhancement jenkins Jenkins related issue rpm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants