Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve docker does not build on dashboards (PR2) #2015

Conversation

peterzhuamazon
Copy link
Member

Signed-off-by: Peter Zhu zhujiaxi@amazon.com

Description

Resolve docker does not build on dashboards (PR2)

Issues Resolved

Part of #1624

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@peterzhuamazon peterzhuamazon requested a review from tianleh April 21, 2022 01:30
@peterzhuamazon peterzhuamazon requested a review from a team as a code owner April 21, 2022 01:30
@peterzhuamazon peterzhuamazon self-assigned this Apr 21, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #2015 (64673ef) into main (d9aa665) will increase coverage by 5.73%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##               main     #2015      +/-   ##
=============================================
+ Coverage     94.26%   100.00%   +5.73%     
=============================================
  Files           195         6     -189     
  Lines          3852       105    -3747     
  Branches         29        19      -10     
=============================================
- Hits           3631       105    -3526     
+ Misses          215         0     -215     
+ Partials          6         0       -6     
Impacted Files Coverage Δ
src/test_workflow/test_args_path_validator.py
src/test_workflow/integ_test/local_test_cluster.py
src/run_manifests.py
src/run_build.py
src/test_workflow/test_args.py
tests/jenkins/jobs/UploadIndexFile_Jenkinsfile
src/run_perf_test.py
...orkflow/ci_check_gradle_dependencies_opensearch.py
src/ci_workflow/ci_check_list.py
src/system/zip_file.py
... and 179 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9aa665...64673ef. Read the comment docs.

@tianleh
Copy link
Member

tianleh commented Apr 21, 2022

looks like containing unrelated changes

@peterzhuamazon peterzhuamazon force-pushed the opensearch-docker-bug-dashboards-2 branch 2 times, most recently from 1a2b67c to e9b0fd8 Compare April 21, 2022 01:35
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
@peterzhuamazon peterzhuamazon force-pushed the opensearch-docker-bug-dashboards-2 branch from e9b0fd8 to b97b967 Compare April 21, 2022 01:36
@peterzhuamazon
Copy link
Member Author

looks like containing unrelated changes

Fixed now.
Thanks.

@peterzhuamazon peterzhuamazon merged commit 1f6a1db into opensearch-project:main Apr 21, 2022
@peterzhuamazon peterzhuamazon deleted the opensearch-docker-bug-dashboards-2 branch April 21, 2022 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants