Update PA directories from plugins to root

[sruti1312]

Signed-off-by: sruti1312 srutiparthiban@gmail.com

Description

OpenSearch moves the plugins config and bin directories into root bin and config folder. This behaviour is similar with all plugins and the expected behaviour. Modifying all PA locations to new root directory location.

Issues Resolved

opensearch-project/OpenSearch#2963

Check List

• Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[saratvemulapalli]

Looks good to me.

[peterzhuamazon]

Better way:

ARG PERFORMANCE_ANALYZER_PLUGIN_NAME=opensearch-performance-analyzer

ARG PERFORMANCE_ANALYZER_PLUGIN_DIR=$OPENSEARCH_HOME/plugins/$PERFORMANCE_ANALYZER_PLUGIN_NAME

[peterzhuamazon]

@sruti1312 I notice that PERFORMANCE_ANALYZER_PLUGIN_DIR is not even used anymore, if you can confirm that please remove it.

Thanks.

[sruti1312]

It is still being used here,
https://github.com/opensearch-project/opensearch-build/blob/main/docker/release/dockerfiles/opensearch.al2.dockerfile#L42

[peterzhuamazon]

That is the wrong location isnt it?

$PERFORMANCE_ANALYZER_PLUGIN_DIR/config/

It resolved to plugins/PA/config which you have already moved to config/PA

[sruti1312]

if [[ -d $PERFORMANCE_ANALYZER_PLUGIN_DIR ]] ; then cp -v $TEMP_DIR/performance-analyzer.properties $OPENSEARCH_HOME/config/$PERFORMANCE_ANALYZER_PLUGIN_NAME/; fi && \

It checks for the plugins directory (which will be present if PA is installed), then copies into the config folder. Check can be modified to the config directory directly.

https://github.com/sruti1312/opensearch-build/blob/feature/pa-files/docker/release/dockerfiles/opensearch.al2.dockerfile#L43

[peterzhuamazon]

Block as there are still many issues.

[codecov-commenter]

Codecov Report

Merging #1987 (e0c9c60) into main (7c732e9) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #1987   +/-   ##
=========================================
  Coverage     94.41%   94.41%           
  Complexity       22       22           
=========================================
  Files           187      187           
  Lines          3739     3739           
  Branches         29       29           
=========================================
  Hits           3530     3530           
  Misses          203      203           
  Partials          6        6           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c732e9...e0c9c60. Read the comment docs.

[dblock]

@davidlago Did we do anything here differently between security and PA?

[davidlago]

@DarshitChanpura @cliu123 could you please confirm things are working as expected after the changes here? I see we did move the config folder outside of the plugins folder. See issue here (thanks @dblock, I was unaware of that issue)