-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the custom security build script #1927
Remove the custom security build script #1927
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1927 +/- ##
=========================================
Coverage 94.60% 94.60%
Complexity 20 20
=========================================
Files 178 178
Lines 3633 3633
Branches 27 27
=========================================
Hits 3437 3437
Misses 192 192
Partials 4 4 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Notifications is going to remove their custom script soon and move to their own repo.
Please avoid using notifications here.
Thanks.
Please give me guidance on how to fix these tests correctly. Switching to the default script doesn't seem to be correct. I am not familiar with the code base to know if this is correct or not. I am just trying to fix the security plugin build break. |
You can create a dummy component in |
Looks like #1929 will resolve the unit test issue, thanks @peterzhuamazon |
Signed-off-by: Peter Nied <petern@amazon.com>
2471ac7
to
597e5d2
Compare
Description
Remove the custom security build script
The build was failing because this script was out of date, by removing this script we can use the default script which I have tested locally
Issue
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.