Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the custom security build script #1927

Conversation

peternied
Copy link
Member

@peternied peternied commented Apr 7, 2022

Description

Remove the custom security build script

The build was failing because this script was out of date, by removing this script we can use the default script which I have tested locally

Issue

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@peternied peternied requested a review from a team as a code owner April 7, 2022 16:28
@peternied peternied changed the title Remove the custom security build script [Blocking] Remove the custom security build script Apr 7, 2022
@codecov-commenter
Copy link

codecov-commenter commented Apr 7, 2022

Codecov Report

Merging #1927 (409dd91) into main (e97b1c9) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #1927   +/-   ##
=========================================
  Coverage     94.60%   94.60%           
  Complexity       20       20           
=========================================
  Files           178      178           
  Lines          3633     3633           
  Branches         27       27           
=========================================
  Hits           3437     3437           
  Misses          192      192           
  Partials          4        4           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e97b1c9...409dd91. Read the comment docs.

@peternied peternied requested a review from peterzhuamazon April 7, 2022 16:47
Copy link
Member

@peterzhuamazon peterzhuamazon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Notifications is going to remove their custom script soon and move to their own repo.
Please avoid using notifications here.

Thanks.

@peternied
Copy link
Member Author

Notifications is going to remove their custom script soon and move to their own repo. Please avoid using notifications here.

Thanks.

Please give me guidance on how to fix these tests correctly. Switching to the default script doesn't seem to be correct. I am not familiar with the code base to know if this is correct or not. I am just trying to fix the security plugin build break.

@peterzhuamazon
Copy link
Member

Notifications is going to remove their custom script soon and move to their own repo. Please avoid using notifications here.
Thanks.

Please give me guidance on how to fix these tests correctly. Switching to the default script doesn't seem to be correct. I am not familiar with the code base to know if this is correct or not. I am just trying to fix the security plugin build break.

You can create a dummy component in tests/data to test this feature.
We are going to move away from saving the custom scripts in component folder.
Switching from security to notifications is just a temp patch that wont run later.

@peternied
Copy link
Member Author

Looks like #1929 will resolve the unit test issue, thanks @peterzhuamazon

Signed-off-by: Peter Nied <petern@amazon.com>
@peternied peternied force-pushed the remote-custom-security-script branch from 2471ac7 to 597e5d2 Compare April 7, 2022 17:59
@peternied peternied requested a review from peterzhuamazon April 7, 2022 18:02
@peterzhuamazon peterzhuamazon changed the title [Blocking] Remove the custom security build script Remove the custom security build script Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG][DISTRIBUTION][2.0.0] Build.sh does not support to use qualifier yet
4 participants