Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix common-utils to find maven artifacts with qualifiers #1796

Merged

Conversation

peterzhuamazon
Copy link
Member

@peterzhuamazon peterzhuamazon commented Mar 22, 2022

Signed-off-by: Peter Zhu zhujiaxi@amazon.com

Description

Fix common-utils to find maven artifacts with qualifiers

Issues Resolved

Part of #1624, #1632
#1790

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
@codecov-commenter
Copy link

codecov-commenter commented Mar 22, 2022

Codecov Report

Merging #1796 (dd0265a) into main (bfb3ad2) will decrease coverage by 0.16%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #1796      +/-   ##
============================================
- Coverage     94.48%   94.32%   -0.17%     
  Complexity       18       18              
============================================
  Files           173      167       -6     
  Lines          3611     3506     -105     
  Branches         27        8      -19     
============================================
- Hits           3412     3307     -105     
  Misses          195      195              
  Partials          4        4              
Impacted Files Coverage Δ
deployment/lambdas/cf-url-rewriter/https-get.ts
deployment/lib/identities.ts
deployment/lib/build-artifact-stack.ts
deployment/lib/artifacts-public-access.ts
...loyment/lambdas/cf-url-rewriter/cf-url-rewriter.ts
deployment/lib/buckets.ts

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bfb3ad2...dd0265a. Read the comment docs.

@dblock dblock merged commit ffd5721 into opensearch-project:main Mar 22, 2022
@peterzhuamazon peterzhuamazon deleted the opensearch-cu-qualifier-fix2 branch March 22, 2022 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants