Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added common-utils with qualifier support to 2.0 manifest. #1741

Merged
merged 1 commit into from
Mar 11, 2022

Conversation

dblock
Copy link
Member

@dblock dblock commented Mar 10, 2022

Signed-off-by: dblock dblock@dblock.org

Description

Added common-utils with qualifier support to 2.0 manifest.

Issues Resolved

Following opensearch-project/common-utils#128 and opensearch-project/common-utils#129.

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: dblock <dblock@dblock.org>
@dblock dblock requested a review from a team as a code owner March 10, 2022 16:30
@codecov-commenter
Copy link

codecov-commenter commented Mar 10, 2022

Codecov Report

Merging #1741 (1a3fc09) into main (aa75906) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #1741   +/-   ##
=========================================
  Coverage     94.79%   94.79%           
  Complexity       17       17           
=========================================
  Files           169      169           
  Lines          3536     3536           
  Branches         26       26           
=========================================
  Hits           3352     3352           
  Misses          181      181           
  Partials          3        3           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa75906...1a3fc09. Read the comment docs.

Copy link
Member

@peterzhuamazon peterzhuamazon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What would happen if QUALIFIER="", will -Dbuild.version_qualifier=$QUALIFIER error out the script?

@peterzhuamazon
Copy link
Member

And does build workflow support adding -q related values already?
Thanks.

@dblock
Copy link
Member Author

dblock commented Mar 10, 2022

What would happen if QUALIFIER="", will -Dbuild.version_qualifier=$QUALIFIER error out the script?

Nope, it will just work as if there's no qualifier.

@dblock
Copy link
Member Author

dblock commented Mar 10, 2022

And does build workflow support adding -q related values already? Thanks.

I believe I have modified scripts in all the right places, but I could be wrong.

@peterzhuamazon peterzhuamazon merged commit f73fbb4 into opensearch-project:main Mar 11, 2022
@dblock dblock deleted the add-common-utils branch March 11, 2022 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants