-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
configure DefaultTTL for CloudFront #1691
Conversation
Signed-off-by: Tianle Huang <tianleh@amazon.com>
Signed-off-by: Tianle Huang <tianleh@amazon.com>
Codecov Report
@@ Coverage Diff @@
## main #1691 +/- ##
=========================================
Coverage 94.74% 94.74%
Complexity 14 14
=========================================
Files 166 166
Lines 3504 3504
Branches 26 26
=========================================
Hits 3320 3320
Misses 181 181
Partials 3 3
Continue to review full report at Codecov.
|
I'll update this PR once the changes are deployed. |
Hi @tianleh The changes have been deployed. Please check. |
checked this. I will check again once there is a newer bundle build for os 1.3.0 |
Just checked again. It is now 1213. Things are working! Thanks @gaiksaya for the support! |
link to the main issue #1492 |
Signed-off-by: Tianle Huang tianleh@amazon.com
Description
As related issue states #1690, we observed that the latest build number is not updating even though the index.json file has changed content. After researching around, figure that the DefaultTTL shall be set to avoid the default behavior of caching for 1 day. Currently I set it to be 5mins to both get a recent build and also low the traffic impact to S3.
Issues Resolved
Resolves #1690
Tests
Current value of index.json https://d17qm4xnop70sv.cloudfront.net/ci/dbc/distribution-build-opensearch/2.0.0/index.json
updating the index.json to be 188.
confirm S3 has the new value.
Refreshing https://d17qm4xnop70sv.cloudfront.net/ci/dbc/distribution-build-opensearch/2.0.0/index.json and still get 166
waiting for 5min and will check again.
We can see that 188 is showing!
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.