Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove docker check for windows gradle check #28

Conversation

peterzhuamazon
Copy link
Member

Signed-off-by: Peter Zhu zhujiaxi@amazon.com

Description

Remove docker check for windows gradle check

Issues Resolved

opensearch-project/opensearch-build#2306

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Copy link
Member

@zelinh zelinh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might need to get the new regression file for groovy test.

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
@codecov-commenter
Copy link

Codecov Report

Merging #28 (014040e) into main (cd10eb5) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main      #28   +/-   ##
=========================================
  Coverage     83.78%   83.78%           
  Complexity       24       24           
=========================================
  Files            62       62           
  Lines           185      185           
  Branches         10       10           
=========================================
  Hits            155      155           
  Misses           24       24           
  Partials          6        6           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@peterzhuamazon peterzhuamazon merged commit 8c4a662 into opensearch-project:main Nov 5, 2022
@peterzhuamazon peterzhuamazon deleted the gradle-check-windows-lib branch November 5, 2022 05:04
peterzhuamazon added a commit to peterzhuamazon/opensearch-build-libraries that referenced this pull request Nov 5, 2022
* Remove docker check for windows gradle check

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>

* add test results

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
peterzhuamazon added a commit to peterzhuamazon/opensearch-build-libraries that referenced this pull request Nov 5, 2022
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
peterzhuamazon added a commit that referenced this pull request Nov 7, 2022
* Added precision for codecov (#17)

* Added precision for codecov

Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>

* Add standard release pipeline library (#11)

* Add standard release pipeline library

Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>

* Create publishToNpm library (#21)

* Add npm publishing lib

Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>

* Add standard release pipeline library with generic trigger (#22)


Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>

* Add release workflow and readme (#23)

* Add release.yml

Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>

* Fix releasing.md (#25)

Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>

Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>

* Fix credential type for github bot (#26)

* Fix credential type for github bot

Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>

* Add untriaged label to new github issues (#27)

Signed-off-by: Rishabh Singh <sngri@amazon.com>

Signed-off-by: Rishabh Singh <sngri@amazon.com>

* Remove docker check for windows gradle check (#28)

* Remove docker check for windows gradle check

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>

* add test results

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>

* Remove docker check for windows gradle check (#28)

* Remove docker check for windows gradle check

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>

* add test results

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>

* upgrade to 1.1.1 with changes in #28

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>

* Test results

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>

Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>
Signed-off-by: Rishabh Singh <sngri@amazon.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Co-authored-by: Owais Kazi <owaiskazi19@gmail.com>
Co-authored-by: Sayali Gaikawad <61760125+gaiksaya@users.noreply.github.com>
Co-authored-by: Rishabh Singh <rishabhksingh@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants