-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove docker check for windows gradle check #28
Merged
peterzhuamazon
merged 2 commits into
opensearch-project:main
from
peterzhuamazon:gradle-check-windows-lib
Nov 5, 2022
Merged
Remove docker check for windows gradle check #28
peterzhuamazon
merged 2 commits into
opensearch-project:main
from
peterzhuamazon:gradle-check-windows-lib
Nov 5, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
1 task
bbarani
approved these changes
Nov 5, 2022
zelinh
reviewed
Nov 5, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might need to get the new regression file for groovy test.
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Codecov Report
@@ Coverage Diff @@
## main #28 +/- ##
=========================================
Coverage 83.78% 83.78%
Complexity 24 24
=========================================
Files 62 62
Lines 185 185
Branches 10 10
=========================================
Hits 155 155
Misses 24 24
Partials 6 6 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
peterzhuamazon
added a commit
to peterzhuamazon/opensearch-build-libraries
that referenced
this pull request
Nov 5, 2022
* Remove docker check for windows gradle check Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * add test results Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
peterzhuamazon
added a commit
to peterzhuamazon/opensearch-build-libraries
that referenced
this pull request
Nov 5, 2022
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
peterzhuamazon
added a commit
that referenced
this pull request
Nov 7, 2022
* Added precision for codecov (#17) * Added precision for codecov Signed-off-by: Owais Kazi <owaiskazi19@gmail.com> * Add standard release pipeline library (#11) * Add standard release pipeline library Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com> * Create publishToNpm library (#21) * Add npm publishing lib Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com> * Add standard release pipeline library with generic trigger (#22) Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com> * Add release workflow and readme (#23) * Add release.yml Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com> * Fix releasing.md (#25) Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com> Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com> * Fix credential type for github bot (#26) * Fix credential type for github bot Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com> * Add untriaged label to new github issues (#27) Signed-off-by: Rishabh Singh <sngri@amazon.com> Signed-off-by: Rishabh Singh <sngri@amazon.com> * Remove docker check for windows gradle check (#28) * Remove docker check for windows gradle check Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * add test results Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Remove docker check for windows gradle check (#28) * Remove docker check for windows gradle check Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * add test results Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * upgrade to 1.1.1 with changes in #28 Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Test results Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> Signed-off-by: Owais Kazi <owaiskazi19@gmail.com> Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com> Signed-off-by: Rishabh Singh <sngri@amazon.com> Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> Co-authored-by: Owais Kazi <owaiskazi19@gmail.com> Co-authored-by: Sayali Gaikawad <61760125+gaiksaya@users.noreply.github.com> Co-authored-by: Rishabh Singh <rishabhksingh@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Peter Zhu zhujiaxi@amazon.com
Description
Remove docker check for windows gradle check
Issues Resolved
opensearch-project/opensearch-build#2306
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.