Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replication namespace #464

Draft
wants to merge 51 commits into
base: main
Choose a base branch
from

Conversation

Tokesh
Copy link
Collaborator

@Tokesh Tokesh commented Aug 3, 2024

Description

adding replication namespace specs

Issues Resolved

[#232]

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Tokesh and others added 4 commits August 3, 2024 22:24
Signed-off-by: Tokesh <tokesh789@gmail.com>
Signed-off-by: Tokesh <tokesh789@gmail.com>
Signed-off-by: Tokesh <tokesh789@gmail.com>
Signed-off-by: Niyazbek Torekeldi <78027392+Tokesh@users.noreply.github.com>
Copy link

github-actions bot commented Aug 3, 2024

Changes Analysis

Commit SHA: 5ed10fb
Comparing To SHA: f150005

API Changes

Summary

├─┬Paths
│ ├──[➕] path (4444:3)
│ ├──[➕] path (4464:3)
│ ├──[➕] path (4542:3)
│ ├──[➕] path (4522:3)
│ ├──[➕] path (4596:3)
│ ├──[➕] path (4579:3)
│ ├──[➕] path (4407:3)
│ ├──[➕] path (4484:3)
│ ├──[➕] path (4504:3)
│ └──[➕] path (4562:3)
└─┬Components
  ├──[➕] requestBodies (24746:7)
  ├──[➕] requestBodies (24734:7)
  ├──[➕] requestBodies (24764:7)
  ├──[➕] requestBodies (24758:7)
  ├──[➕] requestBodies (24752:7)
  ├──[➕] requestBodies (24728:7)
  ├──[➕] requestBodies (24740:7)
  ├──[➕] responses (27220:7)
  ├──[➕] responses (27225:7)
  ├──[➕] responses (27170:7)
  ├──[➕] responses (27178:7)
  ├──[➕] responses (27191:7)
  ├──[➕] responses (27165:7)
  ├──[➕] responses (27186:7)
  ├──[➕] responses (27196:7)
  ├──[➕] responses (27212:7)
  ├──[➕] responses (27204:7)
  ├──[➕] responses (27233:7)
  ├──[➕] parameters (21500:7)
  ├──[➕] parameters (21476:7)
  ├──[➕] parameters (21508:7)
  ├──[➕] parameters (21492:7)
  ├──[➕] parameters (21468:7)
  ├──[➕] parameters (21484:7)
  ├──[➕] schemas (50581:7)
  ├──[➕] schemas (50616:7)
  ├──[➕] schemas (50759:7)
  ├──[➕] schemas (50598:7)
  ├──[➕] schemas (50750:7)
  ├──[➕] schemas (50698:7)
  ├──[➕] schemas (50609:7)
  ├──[➕] schemas (50564:7)
  ├──[➕] schemas (50674:7)
  ├──[➕] schemas (50735:7)
  ├──[➕] schemas (50681:7)
  ├──[➕] schemas (50653:7)
  ├──[➕] schemas (50771:7)
  ├──[➕] schemas (50721:7)
  └──[➕] schemas (50730:7)

Document Element Total Changes Breaking Changes
paths 10 0
components 39 0
  • Total Changes: 49
  • Additions: 49

Report

The full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/10727377265/artifacts/1898205586

API Coverage

Before After Δ
Covered (%) 533 (52.2 %) 544 (53.28 %) 11 (1.08 %)
Uncovered (%) 488 (47.8 %) 477 (46.72 %) -11 (-1.08 %)
Unknown 26 26 0

Signed-off-by: Tokesh <tokesh789@gmail.com>
Signed-off-by: Tokesh <tokesh789@gmail.com>
Signed-off-by: Tokesh <tokesh789@gmail.com>
Signed-off-by: Tokesh <tokesh789@gmail.com>
Signed-off-by: Tokesh <tokesh789@gmail.com>
Signed-off-by: Tokesh <tokesh789@gmail.com>
@dblock
Copy link
Member

dblock commented Aug 3, 2024

Should we split the docker-compose.yml into docker-compose-default, docker-compose-multinode.yml or something like that?

@Tokesh
Copy link
Collaborator Author

Tokesh commented Aug 3, 2024

Should we split the docker-compose.yml into docker-compose-default, docker-compose-multinode.yml or something like that?

wow, do you work even on weekends?
Yes, I encountered this today, tested it on a local machine. Now I was thinking of asking whether it is worth separating or inventing some flags.

@dblock
Copy link
Member

dblock commented Aug 7, 2024

Take a look at #472 that allows custom docker compose and tests.

@Tokesh
Copy link
Collaborator Author

Tokesh commented Aug 7, 2024

Take a look at #472 that allows custom docker compose and tests.

Thank you! It looks really good
I'll wait for your PR to merge so I can continue working on the replication namespace.

@dblock
Copy link
Member

dblock commented Aug 13, 2024

Take a look at #472 that allows custom docker compose and tests.

Thank you! It looks really good I'll wait for your PR to merge so I can continue working on the replication namespace.

@Tokesh that got merged FYI

Copy link

Spec Test Coverage Analysis

Total Tested
561 216 (38.5 %)

Signed-off-by: Tokesh <tokesh789@gmail.com>
Signed-off-by: Tokesh <tokesh789@gmail.com>
Signed-off-by: Tokesh <tokesh789@gmail.com>
Signed-off-by: Tokesh <tokesh789@gmail.com>
Signed-off-by: Tokesh <tokesh789@gmail.com>
Signed-off-by: Tokesh <tokesh789@gmail.com>
Signed-off-by: Tokesh <tokesh789@gmail.com>
Signed-off-by: Tokesh <tokesh789@gmail.com>
Signed-off-by: Tokesh <tokesh789@gmail.com>
Signed-off-by: Tokesh <tokesh789@gmail.com>
Signed-off-by: Tokesh <tokesh789@gmail.com>
Signed-off-by: Tokesh <tokesh789@gmail.com>
Signed-off-by: Tokesh <tokesh789@gmail.com>
Signed-off-by: Tokesh <tokesh789@gmail.com>
Signed-off-by: Tokesh <tokesh789@gmail.com>
Signed-off-by: Tokesh <tokesh789@gmail.com>
Signed-off-by: Tokesh <tokesh789@gmail.com>
Signed-off-by: Tokesh <tokesh789@gmail.com>
Signed-off-by: Tokesh <tokesh789@gmail.com>
Signed-off-by: Tokesh <tokesh789@gmail.com>
Signed-off-by: Tokesh <tokesh789@gmail.com>
Signed-off-by: Tokesh <tokesh789@gmail.com>
Signed-off-by: Tokesh <tokesh789@gmail.com>
@Tokesh
Copy link
Collaborator Author

Tokesh commented Aug 15, 2024

Take a look at #472 that allows custom docker compose and tests.

Thank you! It looks really good I'll wait for your PR to merge so I can continue working on the replication namespace.

@Tokesh that got merged FYI

I have some problems with role mapping. Can you help me please? I got this

(Expected status 200, but received 403: application/json. No user found for indices:admin/plugins/replication/index/setup/validate)

@dblock
Copy link
Member

dblock commented Aug 15, 2024

Take a look at #472 that allows custom docker compose and tests.

Thank you! It looks really good I'll wait for your PR to merge so I can continue working on the replication namespace.

@Tokesh that got merged FYI

I have some problems with role mapping. Can you help me please? I got this

(Expected status 200, but received 403: application/json. No user found for indices:admin/plugins/replication/index/setup/validate)

I am not familiar with this, maybe @cwperks?

@dblock
Copy link
Member

dblock commented Aug 22, 2024

Want to finish this @Tokesh?

@Tokesh
Copy link
Collaborator Author

Tokesh commented Sep 4, 2024

Want to finish this @Tokesh?

Oh, i didnt see your message. Actually, it works on my local computer. I'm still struggling with role mappings

@dblock
Copy link
Member

dblock commented Sep 4, 2024

Want to finish this @Tokesh?

Oh, i didnt see your message. Actually, it works on my local computer. I'm still struggling with role mappings

LMK what kind of help you need? Rebase and I can help fix any failures here?

Signed-off-by: Niyazbek Torekeldi <78027392+Tokesh@users.noreply.github.com>
Signed-off-by: Niyazbek Torekeldi <78027392+Tokesh@users.noreply.github.com>
Signed-off-by: Niyazbek Torekeldi <78027392+Tokesh@users.noreply.github.com>
Signed-off-by: Niyazbek Torekeldi <78027392+Tokesh@users.noreply.github.com>
Signed-off-by: Niyazbek Torekeldi <78027392+Tokesh@users.noreply.github.com>
Signed-off-by: Niyazbek Torekeldi <78027392+Tokesh@users.noreply.github.com>
Signed-off-by: Niyazbek Torekeldi <78027392+Tokesh@users.noreply.github.com>
@Tokesh
Copy link
Collaborator Author

Tokesh commented Sep 5, 2024

LMK what kind of help you need? Rebase and I can help fix any failures here?

Yeap, if it's possible please!

When I did everything locally, I did not encounter such problems. Perhaps I missed something somewhere. Perhaps I do not act on the admin side, but I tested different hypotheses. I will be glad if you help me. I tried to send you the documentation, perhaps I read something wrong.

refs:
Link

@dblock
Copy link
Member

dblock commented Sep 5, 2024

@Tokesh For the linter run npm run lint--fix, see what comes out?

The errors in the tests seem pretty straightforward:

ERROR   RESPONSE STATUS (Expected status 200, but received 403: application/json. No user found for indices:admin/plugins/replication/index/setup/validate)

Sounds like something that exists in your instance but not in a clean setup? You can always docker system prune and see if you can reproduce?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants