Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub workflow file. #35

Merged
merged 12 commits into from
Jun 3, 2022
Merged

GitHub workflow file. #35

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
5612465
GitHub workflow file.
May 13, 2022
6eb89bc
Modifications in CI workflow file.
May 13, 2022
0c418b6
Driver-code and test-case for Ping API is added.
May 13, 2022
b24c99a
New-lines added.
May 18, 2022
0a9ba91
Table added in driver-code for displaying failed result, added commen…
May 19, 2022
866ef98
command for installing Pretty-table module in python is added.
May 19, 2022
30dbb2b
Added code for displaying count of test-cases passed/failed.
May 19, 2022
f58fc02
Adding pipfile, pipfile.lock for python modules , package.json and pa…
May 30, 2022
d3bf572
Updating CI workflow file.
Jun 1, 2022
9855ca4
updating python_version to wildcard.
Jun 1, 2022
1811afc
Separate file created for shell script.
Jun 2, 2022
fa51b02
Removal of extra character in a file.
Jun 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 43 additions & 0 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
name: CI
pgtgrly marked this conversation as resolved.
Show resolved Hide resolved

on: [push, pull_request]

jobs:
run_tests:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2

- name: Use Node.js
uses: actions/setup-node@v1

- name: Installing Dredd
run: sudo npm install dredd --global --unsafe-perm=true --allow-root

- name: Installing node-fetch module
run: npm install node-fetch@2

- name: Installing hooks module
run: npm install hooks

- name: Installing https module
run: npm install https

- name: Installing file module
run: npm install fs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend making a package.json, doing npm install and committing a .lock file, or else this will be a moving target and will break continuously.

Copy link
Contributor Author

@SOPHIA2401 SOPHIA2401 Jun 1, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added package.json and .lock file for all node modules in the commit f58fc02 except the dredd module because of it's broken npm install. I have reached out to the dredd team for the same.


- name: Build the stack
run: docker-compose up -d
shell: bash
working-directory: ./test

- name: Setting up OpenSearch domain
Copy link
Contributor

@pgtgrly pgtgrly May 13, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's rename it to Waiting for Opensearch Domain to be up

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renamed to "Waiting for OpenSearch domain to be up."

run: python ./.github/workflows/test_url.py

- name: Run script file
run: |
export NODE_TLS_REJECT_UNAUTHORIZED=0
pgtgrly marked this conversation as resolved.
Show resolved Hide resolved
python driver-code.py
shell: bash
working-directory: ./test

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add newline to end of file

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added in latest commit.

11 changes: 11 additions & 0 deletions .github/workflows/test_url.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
import os

for i in range(0,6):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens if the domain is not up when i = 6? we need to throw an error

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected in commit 6eb89bc.

command = "curl 'https://admin:admin@localhost:9200' -H 'Content-Type:application/json' --insecure -v"
result = os.system(command)
if result !=0:
os.system("sleep 30s")
else:
os.system("sleep 30s")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we adding sleep here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another 30 seconds are required for the OpenSearch domain to become operational.

break
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can it be directly written in shell script as part of CI workflow?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, It can be added and corrected in commit 6eb89bc.