Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated workflows and version to 3.0.0 #905

Merged
merged 5 commits into from
Oct 20, 2022
Merged

Conversation

ps48
Copy link
Member

@ps48 ps48 commented Jul 28, 2022

Signed-off-by: Shenoy Pratik sgguruda@amazon.com

Description

updated workflows and version to 3.0.0

Issues Resolved

#869

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
@ps48 ps48 requested a review from a team as a code owner July 28, 2022 19:00
kavithacm
kavithacm previously approved these changes Jul 28, 2022
@ps48
Copy link
Member Author

ps48 commented Jul 28, 2022

Backend plugin fails due to missing Job Scheduler artifact

@anirudha
Copy link
Collaborator

closing older test PR with conflict.

@anirudha anirudha closed this Sep 19, 2022
@ps48 ps48 reopened this Sep 29, 2022
@codecov-commenter
Copy link

codecov-commenter commented Sep 29, 2022

Codecov Report

Merging #905 (4295004) into main (249ab50) will decrease coverage by 5.94%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main     #905      +/-   ##
============================================
- Coverage     53.49%   47.54%   -5.95%     
============================================
  Files           279      237      -42     
  Lines          9454     7143    -2311     
  Branches       2215     1975     -240     
============================================
- Hits           5057     3396    -1661     
+ Misses         4227     3718     -509     
+ Partials        170       29     -141     
Flag Coverage Δ
dashboards-observability 47.54% <ø> (ø)
opensearch-observability ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rg/opensearch/observability/ObservabilityPlugin.kt
.../org/opensearch/observability/model/Application.kt
...earch/observability/action/ObservabilityActions.kt
...arch/observability/model/ObservabilityObjectDoc.kt
...rg/opensearch/observability/model/SearchResults.kt
...ability/action/DeleteObservabilityObjectRequest.kt
...pensearch/observability/settings/PluginSettings.kt
.../observability/resthandler/SchedulerRestHandler.kt
...pensearch/observability/security/SecurityAccess.kt
...lin/org/opensearch/observability/model/Notebook.kt
... and 32 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ps48
Copy link
Member Author

ps48 commented Oct 4, 2022

Bwc tests fail here, related to: opensearch-project/job-scheduler#242
Working on the fix #1071

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
@ps48
Copy link
Member Author

ps48 commented Oct 14, 2022

Seeing this error during bwc testing, This is coming from upstream change in common-utils

> Task :compileTestKotlin FAILED
e: /home/ubuntu/check_ci/observability/opensearch-observability/src/test/kotlin/org/opensearch/observability/PluginRestTestCase.kt: (9, 19): Unresolved reference: http
e: /home/ubuntu/check_ci/observability/opensearch-observability/src/test/kotlin/org/opensearch/observability/PluginRestTestCase.kt: (63, 83): Unresolved reference: value
e: /home/ubuntu/check_ci/observability/opensearch-observability/src/test/kotlin/org/opensearch/observability/PluginRestTestCase.kt: (100, 63): Unresolved reference: HttpHost
e: /home/ubuntu/check_ci/observability/opensearch-observability/src/test/kotlin/org/opensearch/observability/PluginRestTestCase.kt: (118, 38): Overload resolution ambiguity:
public open fun builder(vararg p0: HttpHost!): RestClientBuilder! defined in org.opensearch.client.RestClient
public open fun builder(vararg p0: Node!): RestClientBuilder! defined in org.opensearch.client.RestClient

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':compileTestKotlin'.
> Compilation error. See log for more details

@ps48 ps48 merged commit 7ad9027 into opensearch-project:main Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants