Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes trace analytics invalid service map and increase span limit #629

Merged
merged 2 commits into from
Apr 8, 2022

Conversation

joshuali925
Copy link
Member

Description

closes #627

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Joshua Li <joshuali925@gmail.com>
Signed-off-by: Joshua Li <joshuali925@gmail.com>
@joshuali925 joshuali925 requested a review from a team as a code owner April 7, 2022 20:34
@codecov-commenter
Copy link

codecov-commenter commented Apr 7, 2022

Codecov Report

Merging #629 (39c5006) into main (69b6193) will decrease coverage by 0.00%.
The diff coverage is 50.00%.

@@             Coverage Diff              @@
##               main     #629      +/-   ##
============================================
- Coverage     55.17%   55.16%   -0.01%     
  Complexity      283      283              
============================================
  Files           240      240              
  Lines          7696     7697       +1     
  Branches       1608     1572      -36     
============================================
  Hits           4246     4246              
- Misses         3276     3281       +5     
+ Partials        174      170       -4     
Flag Coverage Δ
dashboards-observability 46.83% <50.00%> (-0.01%) ⬇️
opensearch-observability 76.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...s/trace_analytics/components/traces/trace_view.tsx 40.00% <0.00%> (-0.75%) ⬇️
...trace_analytics/requests/queries/traces_queries.ts 31.42% <100.00%> (ø)
...public/components/visualizations/visualization.tsx 10.00% <0.00%> (ø)
...lic/components/visualizations/charts/text/text.tsx 40.00% <0.00%> (ø)
...ig_editor/config_controls/config_panel_options.tsx 16.66% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69b6193...39c5006. Read the comment docs.

@joshuali925 joshuali925 merged commit 533eda1 into opensearch-project:main Apr 8, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 8, 2022
Signed-off-by: Joshua Li <joshuali925@gmail.com>
(cherry picked from commit 533eda1)
joshuali925 added a commit that referenced this pull request Apr 14, 2022
…) (#632)

Signed-off-by: Joshua Li <joshuali925@gmail.com>
(cherry picked from commit 533eda1)

Co-authored-by: Joshua Li <joshuali925@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increase maximum number of spans in gantt chart
4 participants