[Bug] performance improvement #1176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ramneet Chopra <ramneet_chopra@persistent.com>
Signed-off-by: Ramneet Chopra <ramneet_chopra@persistent.com>
ramneet-persistent
force-pushed
the
bug/performance-improvement
branch
from
a2c6858
to
27f9763
Compare
Codecov Report
@@ Coverage Diff @@
## main #1176 +/- ##
============================================
- Coverage 53.70% 53.65% -0.05%
Complexity 291 291
============================================
Files 279 279
Lines 9490 9469 -21
Branches 2244 2231 -13
============================================
- Hits 5097 5081 -16
+ Misses 4223 4218 -5
Partials 170 170
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
mengweieric
reviewed
Oct 21, 2022
mengweieric
reviewed
Oct 21, 2022
| console.log('IN FETCH DATA TEST@@@@ ===EXPLORER ======== updatedQuery', updatedQuery); | ||
| const curQuery = updatedQuery.query; | ||
| console.log('curQuery====', curQuery, 'appBasedRef.current', appBasedRef.current); | ||
| // const rawQueryStr = buildQuery(appBasedRef.current, curQuery![RAW_QUERY]); |
There was a problem hiding this comment.
you may remove loggings/comments next time before committing or merge these in one commit that only contains logging/comments removed version so it could help to remove noice in PR review
ps48
approved these changes
Oct 21, 2022
mengweieric
approved these changes
Oct 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Multiple re-renders in case of update chart fixed
Issues Resolved
Bug #1163
Please note
Fix is only tested for event analytics for now. This pr may require fixes from PR #1147. Once #1147 is merged and these changes are approved will update this PR