Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'getName is not a function' issue for query manager #1160

Conversation

mengweieric
Copy link
Collaborator

@mengweieric mengweieric commented Oct 20, 2022

Description

Fix 'getName is not a function' issue

Issues Resolved

#1042

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Eric Wei <menwe@amazon.com>
@mengweieric mengweieric requested a review from a team as a code owner October 20, 2022 05:34
@codecov-commenter
Copy link

codecov-commenter commented Oct 20, 2022

Codecov Report

Merging #1160 (721eb3e) into main (7930865) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##               main    #1160      +/-   ##
============================================
- Coverage     53.72%   53.70%   -0.02%     
  Complexity      291      291              
============================================
  Files           279      279              
  Lines          9486     9488       +2     
  Branches       2242     2244       +2     
============================================
  Hits           5096     5096              
- Misses         4220     4222       +2     
  Partials        170      170              
Flag Coverage Δ
dashboards-observability 47.86% <0.00%> (-0.02%) ⬇️
opensearch-observability 71.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...mon/query_manager/ast/builder/stats_ast_builder.ts 0.00% <0.00%> (ø)
.../common/query_manager/ast/builder/stats_builder.ts 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mengweieric mengweieric merged commit a3955ef into opensearch-project:main Oct 20, 2022
@mengweieric mengweieric deleted the issue/query-manager-null-issue branch October 20, 2022 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants