[Build] add common to tsconfig #411
Conversation
Need to include common to be compiled down with the release artifact. Issue resolved: opensearch-project#410 Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #411 +/- ##
============================================
- Coverage 70.40% 70.35% -0.06%
Complexity 81 81
============================================
Files 123 123
Lines 3849 3849
Branches 612 612
============================================
- Hits 2710 2708 -2
- Misses 960 962 +2
Partials 179 179
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
@kavilla Was this always a requirement? Dashboards didn't fail to come up when I was testing Notifications locally. How can we reproduce this on our side in the future to avoid catching at the time of the full distribution build? |
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
|
@qreshi yeah it would be acceptable with TypeScript files but when we compile down the files when producing a release artifact we have to tell the compiler to include these files. |
|
Looks like since This can probably be added to the GitHub Actions workflow later so it uses the built artifact and catches discrepancies like this. |
|
Created an issue for tracking the above: #412 |
Description
Need to include common to be compiled down with the release
artifact
Signed-off-by: Kawika Avilla kavilla414@gmail.com
Issues Resolved
#410
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.