Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for -Dbuild.version_qualifier and remove usage of mapping types #388

Merged
merged 2 commits into from
Mar 29, 2022

Conversation

qreshi
Copy link
Contributor

@qreshi qreshi commented Mar 29, 2022

Description

  • Adds support for -Dbuild.version_qualifier in build.gradle
  • Changes OpenSearch version being used from 2.0.0 to 2.0.0-alpha1
  • Removes usage of mapping types

Issues Resolved

#379 #375

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

qreshi added 2 commits March 28, 2022 11:45
Signed-off-by: Mohammad Qureshi <47198598+qreshi@users.noreply.github.com>
Signed-off-by: Mohammad Qureshi <47198598+qreshi@users.noreply.github.com>
@qreshi qreshi requested a review from a team March 29, 2022 00:01
@qreshi
Copy link
Contributor Author

qreshi commented Mar 29, 2022

The backend GitHub Actions are failing because the common-utils snapshot is a couple of days old which had some changes for Notifications (I believe the infra team is looking into the blocker but it's not due to common-utils itself).

The frontend GitHub Actions are failing because changes in OpenSearch-Dashboards seems to have caused minor differences in the rendered output in the Jest tests. I checked the output and tested manually and the functionality seems to be unaffected so I'll submit a follow-up PR to update the snapshots.

@qreshi
Copy link
Contributor Author

qreshi commented Mar 29, 2022

Backend tests are passing locally though (with common-utils published locally):

qreshi@186590ce20fd notifications % ./gradlew build
=======================================
OpenSearch Build Hamster says Hello!
  Gradle Version        : 7.3
  OS Info               : Mac OS X 10.16 (x86_64)
  JDK Version           : 14 (OpenJDK)
  JAVA_HOME             : /Library/Java/JavaVirtualMachines/jdk-14.0.1.jdk/Contents/Home
  Random Testing Seed   : 24D2FCE440F7256E
  In FIPS 140 mode      : false
=======================================

...

BUILD SUCCESSFUL in 6m 39s
55 actionable tasks: 13 executed, 42 up-to-date

@qreshi qreshi merged commit 567f1fc into opensearch-project:main Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants