Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add validations from appsec #562

Merged
merged 10 commits into from
Jan 31, 2024
Merged

Add validations from appsec #562

merged 10 commits into from
Jan 31, 2024

Commits on Jan 26, 2024

  1. add validations from appsec 

    Signed-off-by: HenryL27 <hmlindeman@yahoo.com>
    @HenryL27
    HenryL27 committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    ed8e581 View commit details
    Browse the repository at this point in the history

  2. update changelog 

    Signed-off-by: HenryL27 <hmlindeman@yahoo.com>
    @HenryL27
    HenryL27 committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    9a6fe41 View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2024

  1. add validation on number of characters in query context path (1024) 

    Signed-off-by: HenryL27 <hmlindeman@yahoo.com>
    @HenryL27
    HenryL27 committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    66d2efd View commit details
    Browse the repository at this point in the history

  2. drop max strlen to 1000 

    Signed-off-by: HenryL27 <hmlindeman@yahoo.com>
    @HenryL27
    HenryL27 committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    a8c4c9e View commit details
    Browse the repository at this point in the history

  3. separate query validation errors; also log them 

    Signed-off-by: HenryL27 <hmlindeman@yahoo.com>
    @HenryL27
    HenryL27 committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    e53c0a1 View commit details
    Browse the repository at this point in the history

  4. remove a superfluous return lol 

    Signed-off-by: HenryL27 <hmlindeman@yahoo.com>
    @HenryL27
    HenryL27 committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    4b17c4a View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2024

  1. Apply suggestions from code review 

    Co-authored-by: Heemin Kim <heemin@amazon.com>
Signed-off-by: HenryL27 <hmlindeman@yahoo.com>
    @HenryL27 @heemin32
    HenryL27 and heemin32 authored Jan 30, 2024
    Configuration menu
    Copy the full SHA
    838755f View commit details
    Browse the repository at this point in the history

  2. use clusterService to get settings rather than environment 

    Signed-off-by: HenryL27 <hmlindeman@yahoo.com>
    @HenryL27
    HenryL27 committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    c03d0b0 View commit details
    Browse the repository at this point in the history

  3. import sneakythrows 

    Signed-off-by: HenryL27 <hmlindeman@yahoo.com>
    @HenryL27
    HenryL27 committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    dba691d View commit details
    Browse the repository at this point in the history

  4. apply spotless and fix embarassing syntax error 

    Signed-off-by: HenryL27 <hmlindeman@yahoo.com>
    @HenryL27
    HenryL27 committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    75adcac View commit details
    Browse the repository at this point in the history