Fixed compilation errors after refactoring in core

[martin-gaievski]

Description

Fixed compilation errors after refactoring in core foundation classes (opensearch-project/OpenSearch#9082)

Check List

• All tests pass
• Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[martin-gaievski]

PR will fail for now because similar fix is missing in ml-commons and k-nn. ml-commons PR merged opensearch-project/ml-commons#1200. knn PR created: opensearch-project/k-NN#1038

[naveentatikonda]

The build is still failing

java.lang.NoClassDefFoundError: org/opensearch/action/ActionListener
»  	at org.opensearch.knn.index.util.Nmslib.<clinit>(Nmslib.java:36)
»  	at org.opensearch.knn.index.util.KNNEngine.<clinit>(KNNEngine.java:28)
»  	at org.opensearch.knn.plugin.KNNPlugin.additionalSettings(KNNPlugin.java:355)
»  	at org.opensearch.plugins.PluginsService.updatedSettings(PluginsService.java:243)
»  	at org.opensearch.node.Node.<init>(Node.java:465)
»  	at org.opensearch.node.Node.<init>(Node.java:388)
»  	at org.opensearch.bootstrap.Bootstrap$5.<init>(Bootstrap.java:242)
»  	at org.opensearch.bootstrap.Bootstrap.setup(Bootstrap.java:242)
»  	at org.opensearch.bootstrap.Bootstrap.init(Bootstrap.java:404)
»  	at org.opensearch.bootstrap.OpenSearch.init(OpenSearch.java:180)
»  	at org.opensearch.bootstrap.OpenSearch.execute(OpenSearch.java:171)
»  	at org.opensearch.cli.EnvironmentAwareCommand.execute(EnvironmentAwareCommand.java:104)
»  	at org.opensearch.cli.Command.mainWithoutErrorHandling(Command.java:138)
»  	at org.opensearch.cli.Command.main(Command.java:101)
»  	at org.opensearch.bootstrap.OpenSearch.main(OpenSearch.java:137)
»  	at org.opensearch.bootstrap.OpenSearch.main(OpenSearch.java:103)
»  Caused by: java.lang.ClassNotFoundException: org.opensearch.action.ActionListener
»  	at java.base/java.net.URLClassLoader.findClass(URLClassLoader.java:445)
»  	at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:592)
»  	at java.base/java.net.FactoryURLClassLoader.loadClass(URLClassLoader.java:872)
»  	at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:525)

[martin-gaievski]

The build is still failing

java.lang.NoClassDefFoundError: org/opensearch/action/ActionListener
»  	at org.opensearch.knn.index.util.Nmslib.<clinit>(Nmslib.java:36)
»  	at org.opensearch.knn.index.util.KNNEngine.<clinit>(KNNEngine.java:28)
»  	at org.opensearch.knn.plugin.KNNPlugin.additionalSettings(KNNPlugin.java:355)
»  	at org.opensearch.plugins.PluginsService.updatedSettings(PluginsService.java:243)
»  	at org.opensearch.node.Node.<init>(Node.java:465)
»  	at org.opensearch.node.Node.<init>(Node.java:388)
»  	at org.opensearch.bootstrap.Bootstrap$5.<init>(Bootstrap.java:242)
»  	at org.opensearch.bootstrap.Bootstrap.setup(Bootstrap.java:242)
»  	at org.opensearch.bootstrap.Bootstrap.init(Bootstrap.java:404)
»  	at org.opensearch.bootstrap.OpenSearch.init(OpenSearch.java:180)
»  	at org.opensearch.bootstrap.OpenSearch.execute(OpenSearch.java:171)
»  	at org.opensearch.cli.EnvironmentAwareCommand.execute(EnvironmentAwareCommand.java:104)
»  	at org.opensearch.cli.Command.mainWithoutErrorHandling(Command.java:138)
»  	at org.opensearch.cli.Command.main(Command.java:101)
»  	at org.opensearch.bootstrap.OpenSearch.main(OpenSearch.java:137)
»  	at org.opensearch.bootstrap.OpenSearch.main(OpenSearch.java:103)
»  Caused by: java.lang.ClassNotFoundException: org.opensearch.action.ActionListener
»  	at java.base/java.net.URLClassLoader.findClass(URLClassLoader.java:445)
»  	at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:592)
»  	at java.base/java.net.FactoryURLClassLoader.loadClass(URLClassLoader.java:872)
»  	at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:525)

this should be fixed after knn change is merged and published to maven

[codecov]

Codecov Report

Merging #249 (6386d5c) into main (2a9f70a) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main     #249   +/-   ##
=========================================
  Coverage     86.29%   86.29%           
  Complexity      340      340           
=========================================
  Files            29       29           
  Lines           992      992           
  Branches        153      153           
=========================================
  Hits            856      856           
  Misses           70       70           
  Partials         66       66           

Files Changed	Coverage Δ
...earch/neuralsearch/ml/MLCommonsClientAccessor.java	92.00% <ø> (ø)
...neuralsearch/processor/TextEmbeddingProcessor.java	92.85% <ø> (ø)
...nsearch/neuralsearch/query/NeuralQueryBuilder.java	89.01% <ø> (ø)