Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update imports. #131

Closed
wants to merge 1 commit into from
Closed

Update imports. #131

wants to merge 1 commit into from

Conversation

Yury-Fridlyand
Copy link

Description

Some components were moved from common to core in opensearch-project/OpenSearch#5902. Then ml-commons were updated to reflect this in opensearch-project/ml-commons#741.
This PR includes:

  • Update imports
  • Reorder imports to keep them in alphabetical order
  • Replace org.apache.lucene.util.SetOnce by org.opensearch.common.SetOnce as it was required to obsoleted API check

Issues Resolved

Fixes #125

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
@Yury-Fridlyand Yury-Fridlyand requested a review from a team March 3, 2023 03:22
@navneet1v
Copy link
Collaborator

navneet1v commented Mar 3, 2023

@Yury-Fridlyand

Thanks for opening this pull request.
We already have a pull request in progress which is fixing this same issue: #129

We are waiting on ml-commons repository to fix their repository zips so that checks can be successful.

@Yury-Fridlyand
Copy link
Author

Oops. You can close my PR, I missed #129.
I fixed ml-commons today in opensearch-project/ml-commons#779. It uploads shadow jars (not zips) and ./gradlew run and ./gradlew build pass.
You can restart GHA to validate.

@navneet1v
Copy link
Collaborator

sure let me close this PR.

@navneet1v navneet1v closed this Mar 3, 2023
@Yury-Fridlyand Yury-Fridlyand deleted the fix-build-issue branch March 3, 2023 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Broken Main branch
2 participants