refactor API input/output/URL; add execute API for non-model based algorithm #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wnbts
reviewed
Nov 22, 2021
client/src/main/java/org/opensearch/ml/client/MachineLearningClient.java
Outdated
Show resolved
Hide resolved
common/src/main/java/org/opensearch/ml/common/parameter/LocalSampleCalculatorOutput.java
Outdated
Show resolved
Hide resolved
wnbts
reviewed
Nov 23, 2021
common/src/main/java/org/opensearch/ml/common/dataframe/DataFrameType.java
Outdated
Show resolved
Hide resolved
common/src/main/java/org/opensearch/ml/common/dataframe/ColumnType.java
Outdated
Show resolved
Hide resolved
ylwu-amzn
force-pushed
the
refactor_api_pr
branch
from
54bf452
to
0039868
Compare
jackiehanyang
previously approved these changes
Nov 24, 2021
ylwu-amzn
force-pushed
the
refactor_api_pr
branch
from
85f9f0e
to
bdb78a2
Compare
…gorithm Signed-off-by: Yaliang Wu <ylwu@amazon.com>
Signed-off-by: Yaliang Wu <ylwu@amazon.com>
Signed-off-by: Yaliang Wu <ylwu@amazon.com>
Signed-off-by: Yaliang Wu <ylwu@amazon.com>
ylwu-amzn
force-pushed
the
refactor_api_pr
branch
from
bdb78a2
to
57beac3
Compare
Signed-off-by: Yaliang Wu <ylwu@amazon.com>
wnbts
approved these changes
Nov 30, 2021
amitgalitz
approved these changes
Nov 30, 2021
This was referenced Dec 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yaliang Wu ylwu@amazon.com
Description
Read
docs/how-to-add-new-algorithm.mdin this PR first to get the overall ideatrain/predictAPIs and non-model basedexecuteAPI.NOTE: Test coverage goes lower than our bar, so just publish this as draft PR. Will add more test and change PR status to ready later.
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.