set model state as partially loaded if unload model from partial nodes #806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yaliang Wu <ylwu@amazon.com>
Zhangxunmt
reviewed
Mar 16, 2023
| @@ -128,7 +139,11 @@ protected UnloadModelNodesResponse newResponse( | |||
| BulkRequest bulkRequest = new BulkRequest(); | |||
| for (String modelId : removedNodeMap.keySet()) { | |||
| UpdateRequest updateRequest = new UpdateRequest(); | |||
| updateRequest.index(ML_MODEL_INDEX).id(modelId).doc(ImmutableMap.of(MODEL_STATE_FIELD, MLModelState.UNLOADED)); | |||
| int removedNodeCount = removedNodeMap.get(modelId).size(); | |||
| MLModelState mlModelState = modelWorkNodeCounts.get(modelId) > removedNodeCount | |||
There was a problem hiding this comment.
No need to check if removedNodeCount > 0 here?
modelWorkNodeCounts.get(modelId) > removedNodeCount && removedNodeCount > 0.
There was a problem hiding this comment.
removedNodeCount will always > 0, check line 121
Zhangxunmt
approved these changes
Mar 16, 2023
jngz-es
approved these changes
Mar 16, 2023
ylwu-amzn
added a commit
to ylwu-amzn/ml-commons
that referenced
this pull request
Mar 16, 2023
opensearch-project#806) Signed-off-by: Yaliang Wu <ylwu@amazon.com>
Merged
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If user deploy model to multiple ML nodes, then unload model from one ML node, the model state will become
UNLOADED. This is not correct. We should set the model state asPARTIALLY_LOADED. This PR fixed this bug.Issues Resolved
#805
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.