-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix guardrail it for 2.19 #3465
Conversation
Signed-off-by: Jing Zhang <jngz@amazon.com>
Can we please cut an issue to come back to this test later? We have a lot @ignore test in our code base. |
by the way why we raised this PR on 2.x? Why not on main? We need this for both branches, right? |
Hi Dhrubo, I plan to fix the issue in next few days before final release, so this pr is only targeting at unblocking building, and the fix will be in main at first. Is it OK for you? |
Merge this one as see multiple PRs failed CI for this IT |
Signed-off-by: Jing Zhang <jngz@amazon.com> (cherry picked from commit 4a26768)
Sure, Merged the PR in main too. |
Signed-off-by: Jing Zhang <jngz@amazon.com> (cherry picked from commit 4a26768)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #3465 +/- ##
============================================
- Coverage 81.34% 80.46% -0.89%
- Complexity 6105 6819 +714
============================================
Files 573 603 +30
Lines 25311 29656 +4345
Branches 2665 3316 +651
============================================
+ Hits 20590 23862 +3272
- Misses 3603 4366 +763
- Partials 1118 1428 +310
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Description
[Describe what this change achieves]
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
--signoff
.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.