Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix guardrail it for 2.19 #3465

Merged
merged 1 commit into from
Jan 30, 2025
Merged

Conversation

jngz-es
Copy link
Collaborator

@jngz-es jngz-es commented Jan 29, 2025

Description

[Describe what this change achieves]

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Jing Zhang <jngz@amazon.com>
@dhrubo-os
Copy link
Collaborator

Can we please cut an issue to come back to this test later? We have a lot @ignore test in our code base.

@jngz-es jngz-es temporarily deployed to ml-commons-cicd-env January 30, 2025 01:10 — with GitHub Actions Inactive
@dhrubo-os
Copy link
Collaborator

by the way why we raised this PR on 2.x? Why not on main? We need this for both branches, right?

@jngz-es
Copy link
Collaborator Author

jngz-es commented Jan 30, 2025

by the way why we raised this PR on 2.x? Why not on main? We need this for both branches, right?

Hi Dhrubo, I plan to fix the issue in next few days before final release, so this pr is only targeting at unblocking building, and the fix will be in main at first. Is it OK for you?

@ylwu-amzn ylwu-amzn merged commit 4a26768 into opensearch-project:2.x Jan 30, 2025
9 of 14 checks passed
@ylwu-amzn
Copy link
Collaborator

Merge this one as see multiple PRs failed CI for this IT

opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 30, 2025
Signed-off-by: Jing Zhang <jngz@amazon.com>
(cherry picked from commit 4a26768)
dhrubo-os pushed a commit that referenced this pull request Jan 30, 2025
Signed-off-by: Jing Zhang <jngz@amazon.com>
(cherry picked from commit 4a26768)

Co-authored-by: Jing Zhang <jngz@amazon.com>
@dhrubo-os
Copy link
Collaborator

by the way why we raised this PR on 2.x? Why not on main? We need this for both branches, right?

Hi Dhrubo, I plan to fix the issue in next few days before final release, so this pr is only targeting at unblocking building, and the fix will be in main at first. Is it OK for you?

Sure, Merged the PR in main too.

opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 30, 2025
Signed-off-by: Jing Zhang <jngz@amazon.com>
(cherry picked from commit 4a26768)
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.46%. Comparing base (66aa200) to head (2595a67).
Report is 178 commits behind head on 2.x.

Additional details and impacted files
@@             Coverage Diff              @@
##                2.x    #3465      +/-   ##
============================================
- Coverage     81.34%   80.46%   -0.89%     
- Complexity     6105     6819     +714     
============================================
  Files           573      603      +30     
  Lines         25311    29656    +4345     
  Branches       2665     3316     +651     
============================================
+ Hits          20590    23862    +3272     
- Misses         3603     4366     +763     
- Partials       1118     1428     +310     
Flag Coverage Δ
ml-commons 80.46% <ø> (-0.89%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

jngz-es added a commit that referenced this pull request Jan 30, 2025
Signed-off-by: Jing Zhang <jngz@amazon.com>
(cherry picked from commit 4a26768)

Co-authored-by: Jing Zhang <jngz@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants