Use custom plugin to publish zips to maven #343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xun Zhang <xunzh@amazon.com>
Zhangxunmt
requested review from
a team,
lezzago and
ylwu-amzn
and removed request for
lezzago
| @@ -238,6 +261,7 @@ configurations.all { | |||
| resolutionStrategy.force 'junit:junit:4.12' | |||
| resolutionStrategy.force 'org.apache.commons:commons-lang3:3.10' | |||
| resolutionStrategy.force 'commons-logging:commons-logging:1.2' | |||
| resolutionStrategy.force 'org.objenesis:objenesis:3.2' | |||
There was a problem hiding this comment.
Hey @Zhangxunmt this change is not part of plugin document, can you please check?
There was a problem hiding this comment.
Hi @prudhvigodithi, thanks for your comment! Yes it's not for this "publish to maven" change, but we will need it anyways in our next feature for adding a new algorithm dependency. It's no harm to include it here before the next PR of adding that algorithm.
There was a problem hiding this comment.
Got it, thanks @Zhangxunmt
ylwu-amzn
approved these changes
Jun 10, 2022
prudhvigodithi
approved these changes
Jun 11, 2022
jackiehanyang
approved these changes
Jun 13, 2022
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 13, 2022
Signed-off-by: Xun Zhang <xunzh@amazon.com> (cherry picked from commit f6e8770)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 13, 2022
Signed-off-by: Xun Zhang <xunzh@amazon.com> (cherry picked from commit f6e8770)
Zhangxunmt
pushed a commit
that referenced
this pull request
Jun 14, 2022
Zhangxunmt
pushed a commit
that referenced
this pull request
Jun 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Xun Zhang xunzh@amazon.com
Description
Follow opensearch-project/opensearch-build#1916 and use custom plugin to publish zips to maven.
Issues Resolved
306
Check List
Run ./gradlew publishPluginZipPublicationToZipStagingRepository, and identified the local-staging-repo directory created.
tree ./
./
├── libs
│ ├── opensearch-ml-2.0.0.0-SNAPSHOT.jar
│ └── opensearch-ml-2.0.0.0-rc1-SNAPSHOT.jar
├── local-staging-repo
│ └── org
│ └── opensearch
│ └── plugin
│ └── opensearch-ml-plugin
│ ├── 2.0.0.0-SNAPSHOT
│ │ ├── maven-metadata.xml
│ │ ├── maven-metadata.xml.md5
│ │ ├── maven-metadata.xml.sha1
│ │ ├── maven-metadata.xml.sha256
│ │ ├── maven-metadata.xml.sha512
│ │ ├── opensearch-ml-plugin-2.0.0.0-20220609.235643-1.pom
│ │ ├── opensearch-ml-plugin-2.0.0.0-20220609.235643-1.pom.md5
│ │ ├── opensearch-ml-plugin-2.0.0.0-20220609.235643-1.pom.sha1
│ │ ├── opensearch-ml-plugin-2.0.0.0-20220609.235643-1.pom.sha256
│ │ ├── opensearch-ml-plugin-2.0.0.0-20220609.235643-1.pom.sha512
│ │ ├── opensearch-ml-plugin-2.0.0.0-20220609.235643-1.zip
│ │ ├── opensearch-ml-plugin-2.0.0.0-20220609.235643-1.zip.md5
│ │ ├── opensearch-ml-plugin-2.0.0.0-20220609.235643-1.zip.sha1
│ │ ├── opensearch-ml-plugin-2.0.0.0-20220609.235643-1.zip.sha256
│ │ └── opensearch-ml-plugin-2.0.0.0-20220609.235643-1.zip.sha512
│ ├── maven-metadata.xml
│ ├── maven-metadata.xml.md5
│ ├── maven-metadata.xml.sha1
│ ├── maven-metadata.xml.sha256
│ └── maven-metadata.xml.sha512
├── lombok
│ └── effective-config
│ ├── lombok-main.config
│ └── lombok-test.config
├── private
│ └── opensearch_tmp
└── tmp
└── jar
└── MANIFEST.MF
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.