Add processed function for remote inference input dataset parameters to convert it back to its orignal datatype #2852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to convert it back to its orignal datatype Signed-off-by: b4sjoo <sicheng.song@outlook.com>
b4sjoo
requested review from
dhrubo-os,
jngz-es,
model-collapse,
rbhavna,
ylwu-amzn,
zane-neo,
Zhangxunmt,
austintlee,
HenryL27,
sam-herman and
xinyual
as code owners
b4sjoo
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
b4sjoo
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
ylwu-amzn
reviewed
Aug 28, 2024
dhrubo-os
reviewed
Aug 28, 2024
|
apply spotless. |
b4sjoo
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
b4sjoo
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
Signed-off-by: b4sjoo <sicheng.song@outlook.com>
b4sjoo
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
b4sjoo
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
b4sjoo
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
b4sjoo
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
b4sjoo
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
b4sjoo
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
|
Tested all automated model interface on a test domain with prediction twice, looks good. |
Zhangxunmt
approved these changes
Aug 28, 2024
mingshl
approved these changes
Aug 28, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 28, 2024
…to convert it back to its orignal datatype (#2852) * Add processed function for remote inference input dataset parameters to convert it back to its orignal datatype Signed-off-by: b4sjoo <sicheng.song@outlook.com> * spotless Signed-off-by: b4sjoo <sicheng.song@outlook.com> * remove debugging print Signed-off-by: b4sjoo <sicheng.song@outlook.com> * Add UTs Signed-off-by: b4sjoo <sicheng.song@outlook.com> * Add UTs Signed-off-by: b4sjoo <sicheng.song@outlook.com> * Spotless Signed-off-by: b4sjoo <sicheng.song@outlook.com> --------- Signed-off-by: b4sjoo <sicheng.song@outlook.com> (cherry picked from commit 0a89537)
b4sjoo
added a commit
that referenced
this pull request
Aug 28, 2024
…to convert it back to its orignal datatype (#2852) (#2855) * Add processed function for remote inference input dataset parameters to convert it back to its orignal datatype Signed-off-by: b4sjoo <sicheng.song@outlook.com> * spotless Signed-off-by: b4sjoo <sicheng.song@outlook.com> * remove debugging print Signed-off-by: b4sjoo <sicheng.song@outlook.com> * Add UTs Signed-off-by: b4sjoo <sicheng.song@outlook.com> * Add UTs Signed-off-by: b4sjoo <sicheng.song@outlook.com> * Spotless Signed-off-by: b4sjoo <sicheng.song@outlook.com> --------- Signed-off-by: b4sjoo <sicheng.song@outlook.com> (cherry picked from commit 0a89537) Co-authored-by: Sicheng Song <sicheng.song@outlook.com>
b4sjoo
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
ylwu-amzn
reviewed
Aug 28, 2024
| String textValue = value.asText(); | ||
| try { | ||
| // Try to parse the string as JSON | ||
| JsonNode parsedValue = mapper.readTree(textValue); |
There was a problem hiding this comment.
can it handle this case that a parameter is string, but it's a json string. For example
"content": "{\"title\": \"hello\"}"
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR add a method to process the parameters field in the remote inference input dataset to convert it back to its original datatype, instead of a string.
Related Issues
In #2829 we have identified a model interface issue, however we found the root cause is the parsing method of
RemoteInferenceInputDatasetwill make all the value insideParametersmap into string. Thus in the model interface validation process we need to parse it back to its original datatype.Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.