add model input validation for local models in ml processor #2610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bhavana Ramaram <rbhavna@amazon.com>
rbhavna
requested review from
b4sjoo,
dhrubo-os,
jngz-es,
model-collapse,
ylwu-amzn,
zane-neo,
Zhangxunmt,
austintlee,
HenryL27,
sam-herman and
xinyual
as code owners
rbhavna
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
rbhavna
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
mingshl
reviewed
Jul 4, 2024
|
|
||
| // if model input is not provided for remote models, use default value | ||
| if (functionName.equalsIgnoreCase("remote")) { | ||
| modelInput = (modelInput != null) ? modelInput : "{ \"parameters\": ${ml_inference.parameters} }"; |
There was a problem hiding this comment.
is it better to be a public static final string as DEFAULT_MODEl_INPUT_FIELD="{ "parameters": ${ml_inference.parameters} }"?
plugin/src/main/java/org/opensearch/ml/processor/MLInferenceIngestProcessor.java
Show resolved
Hide resolved
rbhavna
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
rbhavna
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
rbhavna
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
rbhavna
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
Signed-off-by: Bhavana Ramaram <rbhavna@amazon.com>
rbhavna
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
rbhavna
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
mingshl
approved these changes
Jul 5, 2024
b4sjoo
approved these changes
Jul 5, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 5, 2024
* add model input validation for local models in ml processor Signed-off-by: Bhavana Ramaram <rbhavna@amazon.com> --------- Signed-off-by: Bhavana Ramaram <rbhavna@amazon.com> (cherry picked from commit 2b953cd)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 5, 2024
* add model input validation for local models in ml processor Signed-off-by: Bhavana Ramaram <rbhavna@amazon.com> --------- Signed-off-by: Bhavana Ramaram <rbhavna@amazon.com> (cherry picked from commit 2b953cd)
mingshl
pushed a commit
to mingshl/ml-commons
that referenced
this pull request
Jul 8, 2024
…ch-project#2610) * add model input validation for local models in ml processor Signed-off-by: Bhavana Ramaram <rbhavna@amazon.com> --------- Signed-off-by: Bhavana Ramaram <rbhavna@amazon.com>
opensearch-trigger-bot bot
added a commit
that referenced
this pull request
Oct 2, 2024
…2615) * add model input validation for local models in ml processor Signed-off-by: Bhavana Ramaram <rbhavna@amazon.com> --------- Signed-off-by: Bhavana Ramaram <rbhavna@amazon.com> (cherry picked from commit 2b953cd) Co-authored-by: Bhavana Ramaram <rbhavna@amazon.com> (cherry picked from commit 6a250dd)
dhrubo-os
pushed a commit
that referenced
this pull request
Oct 2, 2024
…2615) (#3044) * add model input validation for local models in ml processor Signed-off-by: Bhavana Ramaram <rbhavna@amazon.com> --------- Signed-off-by: Bhavana Ramaram <rbhavna@amazon.com> (cherry picked from commit 2b953cd) Co-authored-by: Bhavana Ramaram <rbhavna@amazon.com> (cherry picked from commit 6a250dd) Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
add model input validation for local models in ml processor
Issues Resolved
(#2601)
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.