Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix local build failure for RestMLInferenceIngestProcessorIT #2402

Merged
merged 1 commit into from
May 3, 2024
Merged

Fix local build failure for RestMLInferenceIngestProcessorIT #2402

merged 1 commit into from
May 3, 2024

Conversation

mingshl
Copy link
Collaborator

@mingshl mingshl commented May 3, 2024

Description

fix local build failure for RestMLInferenceIngestProcessorIT

when openai key is null, skip running predict

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@mingshl
when key is null, skip running predict
7e5fa53 
Signed-off-by: Mingshi Liu <mingshl@amazon.com>
@mingshl mingshl temporarily deployed to ml-commons-cicd-env May 3, 2024 02:31 — with GitHub Actions Inactive
@mingshl mingshl had a problem deploying to ml-commons-cicd-env May 3, 2024 02:31 — with GitHub Actions Error
@mingshl mingshl had a problem deploying to ml-commons-cicd-env May 3, 2024 02:31 — with GitHub Actions Failure
@mingshl mingshl had a problem deploying to ml-commons-cicd-env May 3, 2024 02:31 — with GitHub Actions Failure
@mingshl mingshl had a problem deploying to ml-commons-cicd-env May 3, 2024 02:31 — with GitHub Actions Error
@mingshl mingshl had a problem deploying to ml-commons-cicd-env May 3, 2024 02:31 — with GitHub Actions Error
@mingshl mingshl temporarily deployed to ml-commons-cicd-env May 3, 2024 03:11 — with GitHub Actions Inactive
@mingshl mingshl had a problem deploying to ml-commons-cicd-env May 3, 2024 03:11 — with GitHub Actions Error
@mingshl mingshl had a problem deploying to ml-commons-cicd-env May 3, 2024 03:11 — with GitHub Actions Failure
@mingshl mingshl had a problem deploying to ml-commons-cicd-env May 3, 2024 03:11 — with GitHub Actions Error
@mingshl mingshl had a problem deploying to ml-commons-cicd-env May 3, 2024 03:11 — with GitHub Actions Error
@mingshl mingshl had a problem deploying to ml-commons-cicd-env May 3, 2024 03:11 — with GitHub Actions Failure
@mingshl mingshl temporarily deployed to ml-commons-cicd-env May 3, 2024 04:21 — with GitHub Actions Inactive
@mingshl mingshl had a problem deploying to ml-commons-cicd-env May 3, 2024 04:21 — with GitHub Actions Error
@mingshl mingshl had a problem deploying to ml-commons-cicd-env May 3, 2024 04:21 — with GitHub Actions Failure
@mingshl mingshl had a problem deploying to ml-commons-cicd-env May 3, 2024 04:21 — with GitHub Actions Error
@mingshl mingshl had a problem deploying to ml-commons-cicd-env May 3, 2024 04:21 — with GitHub Actions Error
@mingshl mingshl temporarily deployed to ml-commons-cicd-env May 3, 2024 04:21 — with GitHub Actions Inactive
ylwu-amzn
ylwu-amzn reviewed May 3, 2024
View reviewed changes
plugin/src/test/java/org/opensearch/ml/rest/RestMLInferenceIngestProcessorIT.java
@@ -115,6 +115,10 @@ public void testMLInferenceProcessorWithObjectFieldType() throws Exception {
String index_name = "daily_index";
createPipelineProcessor(createPipelineRequestBody, "diary_embedding_pipeline");
createIndex(index_name, createIndexRequestBody);
// Skip test if key is null
if (OPENAI_KEY == null) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you share the failure message ? Curious why OPENAI_KEY will be null. If this is null, then our IT will always fail.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This happens only in local environment, when we don't set the OPENAI_KEY and it will be null and the IT will eventually fail. Same scenario for the OS 2.14 build I think as they don't have the OPENAI_KEY in their environment, these test will fail : https://build.ci.opensearch.org/blue/rest/organizations/jenkins/pipelines/integ-test/runs/8248/nodes/118/steps/383/log/?start=0

@mingshl mingshl merged commit 950f864 into opensearch-project:main May 3, 2024
7 of 11 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request May 3, 2024
@mingshl @github-actions
when key is null, skip running predict (#2402)
6362062 
(cherry picked from commit 950f864)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request May 3, 2024
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request May 3, 2024
@mingshl @github-actions
when key is null, skip running predict (#2402)
0ff7a5d 
(cherry picked from commit 950f864)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request May 3, 2024
Merged
dhrubo-os pushed a commit that referenced this pull request May 3, 2024
@opensearch-trigger-bot @mingshl
when key is null, skip running predict (#2402) (#2403)
ba80a3a 
(cherry picked from commit 950f864)

Co-authored-by: Mingshi Liu <mingshl@amazon.com>
mingshl pushed a commit that referenced this pull request May 3, 2024
@opensearch-trigger-bot
when key is null, skip running predict (#2402) (#2404)
29f443f
dhrubo-os pushed a commit to dhrubo-os/ml-commons that referenced this pull request May 17, 2024
@opensearch-trigger-bot @mingshl @dhrubo-os
when key is null, skip running predict (opensearch-project#2402) (ope…
9854162 
…nsearch-project#2403)

(cherry picked from commit 950f864)

Co-authored-by: Mingshi Liu <mingshl@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ylwu-amzn ylwu-amzn ylwu-amzn left review comments

@b4sjoo b4sjoo b4sjoo approved these changes

@dhrubo-os dhrubo-os dhrubo-os approved these changes

@jngz-es jngz-es Awaiting requested review from jngz-es jngz-es is a code owner

@model-collapse model-collapse Awaiting requested review from model-collapse model-collapse is a code owner

@rbhavna rbhavna Awaiting requested review from rbhavna rbhavna is a code owner

@zane-neo zane-neo Awaiting requested review from zane-neo zane-neo is a code owner

@Zhangxunmt Zhangxunmt Awaiting requested review from Zhangxunmt Zhangxunmt is a code owner

@austintlee austintlee Awaiting requested review from austintlee austintlee is a code owner

@HenryL27 HenryL27 Awaiting requested review from HenryL27 HenryL27 is a code owner

@sam-herman sam-herman Awaiting requested review from sam-herman

@xinyual xinyual Awaiting requested review from xinyual xinyual is a code owner

Assignees
No one assigned
Labels
backport 2.x backport 2.14
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mingshl @ylwu-amzn @dhrubo-os @b4sjoo