feat: Add search index tool #2356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yuye-aws <yuyezhu@amazon.com>
Signed-off-by: yuye-aws <yuyezhu@amazon.com>
yuye-aws
requested review from
b4sjoo,
dhrubo-os,
jngz-es,
model-collapse,
rbhavna,
ylwu-amzn,
zane-neo,
Zhangxunmt,
austintlee,
HenryL27,
sam-herman and
xinyual
as code owners
yuye-aws
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
yuye-aws
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
yuye-aws
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
yuye-aws
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
yuye-aws
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
yuye-aws
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
Signed-off-by: yuye-aws <yuyezhu@amazon.com>
yuye-aws
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
yuye-aws
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
yuye-aws
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
yuye-aws
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
yuye-aws
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
yuye-aws
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
|
@ylwu-amzn Please help attach backport 2.x label. |
yuye-aws
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
yuye-aws
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
yuye-aws
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
yuye-aws
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
yuye-aws
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
yuye-aws
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
yuye-aws
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
yuye-aws
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
yuye-aws
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
yuye-aws
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
yuye-aws
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
yuye-aws
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
yuye-aws
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
yuye-aws
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
yuye-aws
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
5 tasks
ylwu-amzn
reviewed
Apr 26, 2024
| @@ -184,6 +184,14 @@ integTest { | |||
| // Set this to true this if you want to see the logs in the terminal test output. | |||
| // note: if left false the log output will still show in your IDE | |||
| testLogging.showStandardStreams = true | |||
|
|
|||
| // Exclude integration test for search index tool for multiple nodes | |||
| // because we cannot get concrete exception message in multi-node cluster | |||
There was a problem hiding this comment.
@yuye-aws Why can't get concrete exception message ?
There was a problem hiding this comment.
In multi node cluster, the original exception message is wrapped with RemoteTransportException, the cause of which is still RemoteTransportException.
There was a problem hiding this comment.
Since this PR is just moving code from skills repo to ml-commons, we can keep it as is. But please create a Github issue for supporting multi-node cluster for this IT.
There was a problem hiding this comment.
Created a bug issue: #2362
Hailong-am
approved these changes
Apr 26, 2024
ylwu-amzn
approved these changes
Apr 26, 2024
mingshl
approved these changes
Apr 26, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 26, 2024
* add search index tool Signed-off-by: yuye-aws <yuyezhu@amazon.com> * add search index tool Signed-off-by: yuye-aws <yuyezhu@amazon.com> * spotless apply Signed-off-by: yuye-aws <yuyezhu@amazon.com> * add integration test for search index tool Signed-off-by: yuye-aws <yuyezhu@amazon.com> * fix unit test error Signed-off-by: yuye-aws <yuyezhu@amazon.com> * run spotless apply Signed-off-by: yuye-aws <yuyezhu@amazon.com> * change json file path for search index tool it Signed-off-by: yuye-aws <yuyezhu@amazon.com> * fix integration test for search index tool Signed-off-by: yuye-aws <yuyezhu@amazon.com> * run spotless apply Signed-off-by: yuye-aws <yuyezhu@amazon.com> * skip multiple node integration test for search index tool Signed-off-by: yuye-aws <yuyezhu@amazon.com> * resolve code duplication in search index tool it Signed-off-by: yuye-aws <yuyezhu@amazon.com> * change method access Signed-off-by: yuye-aws <yuyezhu@amazon.com> * remove unused class Signed-off-by: yuye-aws <yuyezhu@amazon.com> * remove wild card import Signed-off-by: yuye-aws <yuyezhu@amazon.com> * add comment in gradle file Signed-off-by: yuye-aws <yuyezhu@amazon.com> --------- Signed-off-by: yuye-aws <yuyezhu@amazon.com> (cherry picked from commit ea7fefa)
mingshl
pushed a commit
that referenced
this pull request
Apr 26, 2024
* add search index tool Signed-off-by: yuye-aws <yuyezhu@amazon.com> * add search index tool Signed-off-by: yuye-aws <yuyezhu@amazon.com> * spotless apply Signed-off-by: yuye-aws <yuyezhu@amazon.com> * add integration test for search index tool Signed-off-by: yuye-aws <yuyezhu@amazon.com> * fix unit test error Signed-off-by: yuye-aws <yuyezhu@amazon.com> * run spotless apply Signed-off-by: yuye-aws <yuyezhu@amazon.com> * change json file path for search index tool it Signed-off-by: yuye-aws <yuyezhu@amazon.com> * fix integration test for search index tool Signed-off-by: yuye-aws <yuyezhu@amazon.com> * run spotless apply Signed-off-by: yuye-aws <yuyezhu@amazon.com> * skip multiple node integration test for search index tool Signed-off-by: yuye-aws <yuyezhu@amazon.com> * resolve code duplication in search index tool it Signed-off-by: yuye-aws <yuyezhu@amazon.com> * change method access Signed-off-by: yuye-aws <yuyezhu@amazon.com> * remove unused class Signed-off-by: yuye-aws <yuyezhu@amazon.com> * remove wild card import Signed-off-by: yuye-aws <yuyezhu@amazon.com> * add comment in gradle file Signed-off-by: yuye-aws <yuyezhu@amazon.com> --------- Signed-off-by: yuye-aws <yuyezhu@amazon.com> (cherry picked from commit ea7fefa) Co-authored-by: Yuye Zhu <yuyezhu@amazon.com>
dhrubo-os
pushed a commit
to dhrubo-os/ml-commons
that referenced
this pull request
May 17, 2024
…ject#2361) * add search index tool Signed-off-by: yuye-aws <yuyezhu@amazon.com> * add search index tool Signed-off-by: yuye-aws <yuyezhu@amazon.com> * spotless apply Signed-off-by: yuye-aws <yuyezhu@amazon.com> * add integration test for search index tool Signed-off-by: yuye-aws <yuyezhu@amazon.com> * fix unit test error Signed-off-by: yuye-aws <yuyezhu@amazon.com> * run spotless apply Signed-off-by: yuye-aws <yuyezhu@amazon.com> * change json file path for search index tool it Signed-off-by: yuye-aws <yuyezhu@amazon.com> * fix integration test for search index tool Signed-off-by: yuye-aws <yuyezhu@amazon.com> * run spotless apply Signed-off-by: yuye-aws <yuyezhu@amazon.com> * skip multiple node integration test for search index tool Signed-off-by: yuye-aws <yuyezhu@amazon.com> * resolve code duplication in search index tool it Signed-off-by: yuye-aws <yuyezhu@amazon.com> * change method access Signed-off-by: yuye-aws <yuyezhu@amazon.com> * remove unused class Signed-off-by: yuye-aws <yuyezhu@amazon.com> * remove wild card import Signed-off-by: yuye-aws <yuyezhu@amazon.com> * add comment in gradle file Signed-off-by: yuye-aws <yuyezhu@amazon.com> --------- Signed-off-by: yuye-aws <yuyezhu@amazon.com> (cherry picked from commit ea7fefa) Co-authored-by: Yuye Zhu <yuyezhu@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add search index tool in the current repo: opensearch-project/skills#294
Issues Resolved
Add search index tool in the current repo: opensearch-project/skills#294
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.