Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add tutorial for CFN template integration #2161

Merged
merged 3 commits into from
Feb 29, 2024
Merged

add tutorial for CFN template integration #2161

merged 3 commits into from
Feb 29, 2024

Conversation

ylwu-amzn
Copy link
Collaborator

Description

Add tutorial for CFN template integration

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ylwu-amzn
add tutorial for CFN template integration
33ef3a6 
Signed-off-by: Yaliang Wu <ylwu@amazon.com>
@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env February 26, 2024 20:43 — with GitHub Actions Inactive
@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env February 26, 2024 20:43 — with GitHub Actions Inactive
@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env February 26, 2024 20:44 — with GitHub Actions Inactive
@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env February 26, 2024 20:44 — with GitHub Actions Inactive
@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env February 26, 2024 20:44 — with GitHub Actions Inactive
@codecov Codecov
Copy link

codecov bot commented Feb 26, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.85%. Comparing base (7b60989) to head (33ef3a6).
Report is 3 commits behind head on main.

❗ Current head 33ef3a6 differs from pull request most recent head cf3abd0. Consider uploading reports for the commit cf3abd0 to get more accurate results

Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #2161      +/-   ##
============================================
- Coverage     81.86%   81.85%   -0.02%     
  Complexity     5659     5659              
============================================
  Files           543      543              
  Lines         22857    22857              
  Branches       2350     2350              
============================================
- Hits          18712    18709       -3     
- Misses         3206     3209       +3     
  Partials        939      939
Flag Coverage Δ
ml-commons 81.85% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Zhangxunmt
Zhangxunmt reviewed Feb 26, 2024
View reviewed changes
docs/tutorials/aws/semantic_search_with_CFN_template_for_Sagemaker.md Outdated

Keep other fields as default value if not mentioned below:
1. You must fill your "Amazon OpenSearch Endpoint"
2. You must fill your "SageMaker Endpoint Url".
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add "For example, https://runtime.sagemaker.us-east-1.amazonaws.com/endpoints//invocations" as an example of the url?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the screenshot has the example

Zhangxunmt
Zhangxunmt previously approved these changes Feb 26, 2024
View reviewed changes
kolchfa-aws
kolchfa-aws reviewed Feb 28, 2024
View reviewed changes
Copy link
Contributor

@kolchfa-aws kolchfa-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments.

docs/tutorials/aws/semantic_search_with_CFN_template_for_Sagemaker.md Outdated Show resolved Hide resolved
docs/tutorials/aws/semantic_search_with_CFN_template_for_Sagemaker.md Outdated Show resolved Hide resolved
docs/tutorials/aws/semantic_search_with_CFN_template_for_Sagemaker.md Outdated Show resolved Hide resolved
docs/tutorials/aws/semantic_search_with_CFN_template_for_Sagemaker.md Outdated Show resolved Hide resolved
docs/tutorials/aws/semantic_search_with_CFN_template_for_Sagemaker.md Outdated Show resolved Hide resolved
docs/tutorials/aws/semantic_search_with_CFN_template_for_Sagemaker.md Outdated Show resolved Hide resolved
docs/tutorials/aws/semantic_search_with_CFN_template_for_Sagemaker.md Outdated Show resolved Hide resolved
docs/tutorials/aws/semantic_search_with_CFN_template_for_Sagemaker.md Outdated Show resolved Hide resolved
docs/tutorials/aws/semantic_search_with_CFN_template_for_Sagemaker.md Outdated Show resolved Hide resolved
docs/tutorials/aws/semantic_search_with_CFN_template_for_Sagemaker.md Outdated Show resolved Hide resolved
@ylwu-amzn @kolchfa-aws
Apply suggestions from code review
a7f2e9f 
Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com>
Signed-off-by: Yaliang Wu <ylwu@amazon.com>
@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env February 28, 2024 17:08 — with GitHub Actions Inactive
@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env February 28, 2024 17:08 — with GitHub Actions Inactive
@ylwu-amzn
add tutorial for bedrock cohere embedding model
cf3abd0 
Signed-off-by: Yaliang Wu <ylwu@amazon.com>
@ylwu-amzn ylwu-amzn temporarily deployed to ml-commons-cicd-env February 29, 2024 00:31 — with GitHub Actions Inactive
@ylwu-amzn ylwu-amzn merged commit 51cc4e4 into opensearch-project:main Feb 29, 2024
4 of 9 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 29, 2024
@ylwu-amzn @github-actions
add tutorial for CFN template integration (#2161)
01fbdbb 
* add tutorial for CFN template integration

Signed-off-by: Yaliang Wu <ylwu@amazon.com>

* Apply suggestions from code review

Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com>
Signed-off-by: Yaliang Wu <ylwu@amazon.com>

* add tutorial for bedrock cohere embedding model

Signed-off-by: Yaliang Wu <ylwu@amazon.com>

---------

Signed-off-by: Yaliang Wu <ylwu@amazon.com>
Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com>
(cherry picked from commit 51cc4e4)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Feb 29, 2024
Merged
ylwu-amzn added a commit that referenced this pull request Feb 29, 2024
@opensearch-trigger-bot @ylwu-amzn
add tutorial for CFN template integration (#2161) (#2166)
698b5e6 
* add tutorial for CFN template integration

Signed-off-by: Yaliang Wu <ylwu@amazon.com>

* Apply suggestions from code review

Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com>
Signed-off-by: Yaliang Wu <ylwu@amazon.com>

* add tutorial for bedrock cohere embedding model

Signed-off-by: Yaliang Wu <ylwu@amazon.com>

---------

Signed-off-by: Yaliang Wu <ylwu@amazon.com>
Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com>
(cherry picked from commit 51cc4e4)

Co-authored-by: Yaliang Wu <ylwu@amazon.com>
austintlee pushed a commit to austintlee/ml-commons that referenced this pull request Mar 19, 2024
@ylwu-amzn @kolchfa-aws @austintlee
add tutorial for CFN template integration (opensearch-project#2161)
27cd2ce 
* add tutorial for CFN template integration

Signed-off-by: Yaliang Wu <ylwu@amazon.com>

* Apply suggestions from code review

Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com>
Signed-off-by: Yaliang Wu <ylwu@amazon.com>

* add tutorial for bedrock cohere embedding model

Signed-off-by: Yaliang Wu <ylwu@amazon.com>

---------

Signed-off-by: Yaliang Wu <ylwu@amazon.com>
Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kolchfa-aws kolchfa-aws kolchfa-aws left review comments

@b4sjoo b4sjoo b4sjoo approved these changes

@rbhavna rbhavna rbhavna approved these changes

@Zhangxunmt Zhangxunmt Zhangxunmt approved these changes

@dhrubo-os dhrubo-os Awaiting requested review from dhrubo-os dhrubo-os is a code owner

@jngz-es jngz-es Awaiting requested review from jngz-es jngz-es is a code owner

@model-collapse model-collapse Awaiting requested review from model-collapse model-collapse is a code owner

@zane-neo zane-neo Awaiting requested review from zane-neo zane-neo is a code owner

@austintlee austintlee Awaiting requested review from austintlee austintlee is a code owner

@HenryL27 HenryL27 Awaiting requested review from HenryL27 HenryL27 is a code owner

@sam-herman sam-herman Awaiting requested review from sam-herman

Assignees
No one assigned
Labels
backport 2.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ylwu-amzn @Zhangxunmt @kolchfa-aws @rbhavna @b4sjoo