Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change searchResponse method to fix breaking change in managed service #1917

Merged
merged 2 commits into from
Jan 25, 2024

Conversation

rbhavna
Copy link
Collaborator

@rbhavna rbhavna commented Jan 24, 2024

Description

change searchResponse method to fix breaking change in managed service

Issues Resolved

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Bhavana Ramaram <rbhavna@amazon.com>
Signed-off-by: Bhavana Ramaram <rbhavna@amazon.com>
@rbhavna rbhavna temporarily deployed to ml-commons-cicd-env January 24, 2024 23:17 — with GitHub Actions Inactive
@rbhavna rbhavna temporarily deployed to ml-commons-cicd-env January 24, 2024 23:17 — with GitHub Actions Inactive
@rbhavna rbhavna temporarily deployed to ml-commons-cicd-env January 24, 2024 23:17 — with GitHub Actions Inactive
@rbhavna rbhavna temporarily deployed to ml-commons-cicd-env January 24, 2024 23:17 — with GitHub Actions Inactive
@rbhavna rbhavna temporarily deployed to ml-commons-cicd-env January 24, 2024 23:17 — with GitHub Actions Inactive
@rbhavna rbhavna temporarily deployed to ml-commons-cicd-env January 24, 2024 23:17 — with GitHub Actions Inactive
Copy link

codecov bot commented Jan 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1910561) 82.62% compared to head (cede70c) 82.63%.
Report is 1 commits behind head on 2.x.

Additional details and impacted files
@@             Coverage Diff              @@
##                2.x    #1917      +/-   ##
============================================
+ Coverage     82.62%   82.63%   +0.01%     
- Complexity     5391     5392       +1     
============================================
  Files           521      521              
  Lines         21733    21733              
  Branches       2210     2210              
============================================
+ Hits          17957    17960       +3     
+ Misses         2879     2876       -3     
  Partials        897      897              
Flag Coverage Δ
ml-commons 82.63% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rbhavna rbhavna temporarily deployed to ml-commons-cicd-env January 24, 2024 23:44 — with GitHub Actions Inactive
@rbhavna rbhavna temporarily deployed to ml-commons-cicd-env January 24, 2024 23:44 — with GitHub Actions Inactive
@rbhavna rbhavna temporarily deployed to ml-commons-cicd-env January 24, 2024 23:44 — with GitHub Actions Inactive
@rbhavna rbhavna merged commit 1dbcb1c into opensearch-project:2.x Jan 25, 2024
15 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to main failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-main main
# Navigate to the new working tree
cd .worktrees/backport-main
# Create a new branch
git switch --create backport/backport-1917-to-main
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 1dbcb1ccdcf960eddd26d236ac65c2bbe98d7ae7
# Push it to GitHub
git push --set-upstream origin backport/backport-1917-to-main
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-main

Then, create a pull request where the base branch is main and the compare/head branch is backport/backport-1917-to-main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants