fix no permission to create model/task index bug;add security IT for train/predict API #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…train/predict API Signed-off-by: Yaliang Wu <ylwu@amazon.com>
amitgalitz
reviewed
Mar 9, 2022
amitgalitz
reviewed
Mar 9, 2022
amitgalitz
reviewed
Mar 9, 2022
amitgalitz
reviewed
Mar 9, 2022
Signed-off-by: Yaliang Wu <ylwu@amazon.com>
Signed-off-by: Yaliang Wu <ylwu@amazon.com>
|
Build failed on some tests that weren't changed on this PR, could be flaky ones |
amitgalitz
approved these changes
Mar 9, 2022
|
Yes, seems flaky test, created an issue to track this #179 |
Zhangxunmt
reviewed
Mar 9, 2022
Zhangxunmt
reviewed
Mar 9, 2022
Zhangxunmt
approved these changes
Mar 9, 2022
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 9, 2022
…train/predict API (#177) * fix no permission to create model/task index bug;add security IT for train/predict API Signed-off-by: Yaliang Wu <ylwu@amazon.com> * add more security IT for readonly user Signed-off-by: Yaliang Wu <ylwu@amazon.com> * throw exception if delete model/task successfully for readonly user Signed-off-by: Yaliang Wu <ylwu@amazon.com> (cherry picked from commit f12ca76)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 9, 2022
…train/predict API (#177) * fix no permission to create model/task index bug;add security IT for train/predict API Signed-off-by: Yaliang Wu <ylwu@amazon.com> * add more security IT for readonly user Signed-off-by: Yaliang Wu <ylwu@amazon.com> * throw exception if delete model/task successfully for readonly user Signed-off-by: Yaliang Wu <ylwu@amazon.com> (cherry picked from commit f12ca76)
ylwu-amzn
added a commit
that referenced
this pull request
Mar 9, 2022
…train/predict API (#177) (#181) * fix no permission to create model/task index bug;add security IT for train/predict API Signed-off-by: Yaliang Wu <ylwu@amazon.com> * add more security IT for readonly user Signed-off-by: Yaliang Wu <ylwu@amazon.com> * throw exception if delete model/task successfully for readonly user Signed-off-by: Yaliang Wu <ylwu@amazon.com> (cherry picked from commit f12ca76) Co-authored-by: Yaliang Wu <ylwu@amazon.com>
ylwu-amzn
added a commit
that referenced
this pull request
Mar 9, 2022
…train/predict API (#177) (#180) * fix no permission to create model/task index bug;add security IT for train/predict API Signed-off-by: Yaliang Wu <ylwu@amazon.com> * add more security IT for readonly user Signed-off-by: Yaliang Wu <ylwu@amazon.com> * throw exception if delete model/task successfully for readonly user Signed-off-by: Yaliang Wu <ylwu@amazon.com> (cherry picked from commit f12ca76) Co-authored-by: Yaliang Wu <ylwu@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yaliang Wu ylwu@amazon.com
Description
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.