add register action request/response #1769

ylwu-amzn · 2023-12-17T00:01:55Z

Description

Add register agent action request/response

Issues Resolved

[List any issues this PR will resolve]

Check List

New functionality includes testing.
- All tests pass
New functionality has been documented.
- New functionality has javadoc added
Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Yaliang Wu <ylwu@amazon.com>

codecov · 2023-12-17T00:22:10Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4d8d32e) 82.53% compared to head (0335a8f) 82.69%.

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #1769      +/-   ##
============================================
+ Coverage     82.53%   82.69%   +0.16%     
- Complexity     4719     4745      +26     
============================================
  Files           459      462       +3     
  Lines         18881    18940      +59     
  Branches       1976     1976              
============================================
+ Hits          15583    15662      +79     
+ Misses         2471     2451      -20     
  Partials        827      827

Flag	Coverage Δ
ml-commons	`82.69% <100.00%> (+0.16%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

common/src/main/java/org/opensearch/ml/common/transport/undeploy/MLUndeployModelsResponse.java

common/src/main/java/org/opensearch/ml/common/agent/LLMSpec.java

common/src/main/java/org/opensearch/ml/common/agent/MLAgent.java

Signed-off-by: Yaliang Wu <ylwu@amazon.com>

dhrubo-os · 2023-12-17T02:41:12Z

common/src/main/java/org/opensearch/ml/common/agent/MLAgent.java

+                for (MLToolSpec toolSpec : tools) {
+                    String toolName = Optional.ofNullable(toolSpec.getName()).orElse(toolSpec.getType());
+                    if (toolNames.contains(toolName)) {
+                        throw new IllegalArgumentException("Tool has duplicate name or alias: " + toolName);


Can we cover this section in test?.

Signed-off-by: Yaliang Wu <ylwu@amazon.com>

Zhangxunmt · 2023-12-17T22:49:20Z

common/src/main/java/org/opensearch/ml/common/agent/MLAgent.java

+            for (MLToolSpec toolSpec : tools) {
+                String toolName = Optional.ofNullable(toolSpec.getName()).orElse(toolSpec.getType());
+                if (toolNames.contains(toolName)) {
+                    throw new IllegalArgumentException("Duplicate tool defined: " + toolName);


Is it expected to throw this exception or just remove the redundancy in the tools and return normally?

Yes, it's expected, we can't remove redundancy for the user automatically as we don't know which one is the correct.

* add register action request/response Signed-off-by: Yaliang Wu <ylwu@amazon.com> * add ut for MLUndeployModelsResponse Signed-off-by: Yaliang Wu <ylwu@amazon.com> * add more ut Signed-off-by: Yaliang Wu <ylwu@amazon.com> --------- Signed-off-by: Yaliang Wu <ylwu@amazon.com> (cherry picked from commit 94c5d21)

* add register action request/response Signed-off-by: Yaliang Wu <ylwu@amazon.com> * add ut for MLUndeployModelsResponse Signed-off-by: Yaliang Wu <ylwu@amazon.com> * add more ut Signed-off-by: Yaliang Wu <ylwu@amazon.com> --------- Signed-off-by: Yaliang Wu <ylwu@amazon.com> (cherry picked from commit 94c5d21) Co-authored-by: Yaliang Wu <ylwu@amazon.com>

* add register action request/response Signed-off-by: Yaliang Wu <ylwu@amazon.com> * add ut for MLUndeployModelsResponse Signed-off-by: Yaliang Wu <ylwu@amazon.com> * add more ut Signed-off-by: Yaliang Wu <ylwu@amazon.com> --------- Signed-off-by: Yaliang Wu <ylwu@amazon.com>

ylwu-amzn requested review from b4sjoo, dhrubo-os, jngz-es, model-collapse, rbhavna, zane-neo, Zhangxunmt, austintlee and HenryL27 as code owners December 17, 2023 00:01

ylwu-amzn had a problem deploying to ml-commons-cicd-env December 17, 2023 00:02 — with GitHub Actions Error

ylwu-amzn had a problem deploying to ml-commons-cicd-env December 17, 2023 00:02 — with GitHub Actions Failure

ylwu-amzn temporarily deployed to ml-commons-cicd-env December 17, 2023 00:02 — with GitHub Actions Inactive

add register action request/response

57225a1

Signed-off-by: Yaliang Wu <ylwu@amazon.com>

ylwu-amzn force-pushed the af_test branch from e38c989 to 57225a1 Compare December 17, 2023 00:03

ylwu-amzn had a problem deploying to ml-commons-cicd-env December 17, 2023 00:03 — with GitHub Actions Error

ylwu-amzn had a problem deploying to ml-commons-cicd-env December 17, 2023 00:03 — with GitHub Actions Failure

ylwu-amzn had a problem deploying to ml-commons-cicd-env December 17, 2023 00:03 — with GitHub Actions Error

ylwu-amzn had a problem deploying to ml-commons-cicd-env December 17, 2023 00:03 — with GitHub Actions Failure

dhrubo-os reviewed Dec 17, 2023

View reviewed changes

common/src/main/java/org/opensearch/ml/common/transport/undeploy/MLUndeployModelsResponse.java Show resolved Hide resolved

dhrubo-os reviewed Dec 17, 2023

View reviewed changes

common/src/main/java/org/opensearch/ml/common/agent/LLMSpec.java Show resolved Hide resolved

dhrubo-os reviewed Dec 17, 2023

View reviewed changes

common/src/main/java/org/opensearch/ml/common/agent/MLAgent.java Show resolved Hide resolved

add ut for MLUndeployModelsResponse

f339dcc

Signed-off-by: Yaliang Wu <ylwu@amazon.com>

ylwu-amzn had a problem deploying to ml-commons-cicd-env December 17, 2023 01:41 — with GitHub Actions Failure

ylwu-amzn had a problem deploying to ml-commons-cicd-env December 17, 2023 01:41 — with GitHub Actions Error

ylwu-amzn had a problem deploying to ml-commons-cicd-env December 17, 2023 01:58 — with GitHub Actions Error

ylwu-amzn had a problem deploying to ml-commons-cicd-env December 17, 2023 02:16 — with GitHub Actions Failure

ylwu-amzn had a problem deploying to ml-commons-cicd-env December 17, 2023 02:16 — with GitHub Actions Error

ylwu-amzn temporarily deployed to ml-commons-cicd-env December 17, 2023 02:16 — with GitHub Actions Inactive

ylwu-amzn had a problem deploying to ml-commons-cicd-env December 17, 2023 02:37 — with GitHub Actions Error

ylwu-amzn had a problem deploying to ml-commons-cicd-env December 17, 2023 02:38 — with GitHub Actions Failure

dhrubo-os reviewed Dec 17, 2023

View reviewed changes

add more ut

0335a8f

Signed-off-by: Yaliang Wu <ylwu@amazon.com>

ylwu-amzn had a problem deploying to ml-commons-cicd-env December 17, 2023 06:39 — with GitHub Actions Error

ylwu-amzn had a problem deploying to ml-commons-cicd-env December 17, 2023 06:39 — with GitHub Actions Failure

ylwu-amzn temporarily deployed to ml-commons-cicd-env December 17, 2023 06:39 — with GitHub Actions Inactive

ylwu-amzn had a problem deploying to ml-commons-cicd-env December 17, 2023 07:01 — with GitHub Actions Failure

ylwu-amzn had a problem deploying to ml-commons-cicd-env December 17, 2023 07:01 — with GitHub Actions Error

dhrubo-os approved these changes Dec 17, 2023

View reviewed changes

Zhangxunmt approved these changes Dec 17, 2023

View reviewed changes

ylwu-amzn merged commit 94c5d21 into opensearch-project:main Dec 17, 2023
8 of 14 checks passed

ylwu-amzn added the backport 2.x label Dec 18, 2023

opensearch-trigger-bot bot mentioned this pull request Dec 18, 2023

[Backport 2.x] add register action request/response #1780

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add register action request/response #1769

add register action request/response #1769

ylwu-amzn commented Dec 17, 2023

codecov bot commented Dec 17, 2023 •

edited

Loading

dhrubo-os Dec 17, 2023

ylwu-amzn Dec 17, 2023

Zhangxunmt Dec 17, 2023

ylwu-amzn Dec 17, 2023

add register action request/response #1769

add register action request/response #1769

Conversation

ylwu-amzn commented Dec 17, 2023

Description

Issues Resolved

Check List

codecov bot commented Dec 17, 2023 • edited Loading

Codecov Report

dhrubo-os Dec 17, 2023

Choose a reason for hiding this comment

ylwu-amzn Dec 17, 2023

Choose a reason for hiding this comment

Zhangxunmt Dec 17, 2023

Choose a reason for hiding this comment

ylwu-amzn Dec 17, 2023

Choose a reason for hiding this comment

codecov bot commented Dec 17, 2023 •

edited

Loading