Add integ tests for model APIs #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ylwu-amzn
reviewed
Mar 7, 2022
| @@ -283,7 +284,16 @@ protected void validateStats( | |||
| } | |||
| assertEquals(expectedTotalFailureCount, totalFailureCount); | |||
| assertEquals(expectedTotalAlgoFailureCount, totalAlgoFailureCount); | |||
| assertEquals(expectedTotalRequestCount, totalRequestCount); | |||
| // ToDo: this line makes this test flaky as other tests makes the request count not predictable | |||
| // assertEquals(expectedTotalRequestCount, totalRequestCount); | |||
There was a problem hiding this comment.
I think it's ok to remove this line, multiple tests against same cluster may have different total requests based on their execution sequence.
ylwu-amzn
reviewed
Mar 7, 2022
| public class RestMLDeleteModelActionIT extends MLCommonsRestTestCase { | ||
|
|
||
| public void testDeleteModelAPI_EmptyResources() throws Exception { | ||
| TestHelper |
There was a problem hiding this comment.
To keep consistent with other code, how about using ExpectedException ?
@Rule
public ExpectedException exceptionRule = ExpectedException.none();
public void testGetModelAPI_EmptyResources() throws IOException {
exceptionRule.expect(ResponseException.class);
exceptionRule.expectMessage("index_not_found_exception");
TestHelper.makeRequest(client(), "DELETE", "/_plugins/_ml/models/111222333", null, "", null);
}
There was a problem hiding this comment.
Yep, updated to use ExpectedException.
Signed-off-by: Xun Zhang <xunzh@amazon.com>
ylwu-amzn
reviewed
Mar 7, 2022
|
|
||
| public class RestMLGetModelActionTests extends OpenSearchTestCase { | ||
| @Rule | ||
| public ExpectedException thrown = ExpectedException.none(); |
There was a problem hiding this comment.
Minor: This is not being used.
You can keep the commit history, especially after first round of review. So review can review what changed only. That can save some time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Xun Zhang xunzh@amazon.com
Description
Add integration tests for all model APIs. Rebased on PR 167.
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.