add fixed in time rcf #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yaliang Wu <ylwu@amazon.com>
kaituo
reviewed
Feb 11, 2022
| pointList.clear(); | ||
| Map<String, Object> result = new HashMap<>(); | ||
|
|
||
| AnomalyDescriptor process = forest.process(point, timestamp); |
There was a problem hiding this comment.
process includes both score and update. How do you prevent training from happening?
There was a problem hiding this comment.
Thanks Kaituo, I have the same question and waiting for ML team's response. I created an issue to make this discussion open on RCF repo aws/random-cut-forest-by-aws#299
This PR is just to leverage we we have and follow the same way of AD plugin.
kaituo
approved these changes
Feb 11, 2022
jackiehanyang
approved these changes
Feb 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yaliang Wu ylwu@amazon.com
Description
Integrate RCF to support anomaly detection on time-series data.
Related PR: aws/random-cut-forest-by-aws#298
Issues Resolved
#139
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.