2.x consistent get interactions #1334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: HenryL27 <hmlindeman@yahoo.com>
Signed-off-by: HenryL27 <hmlindeman@yahoo.com>
HenryL27
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
HenryL27
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
HenryL27
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
HenryL27
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
ylwu-amzn
reviewed
Sep 13, 2023
memory/src/main/java/org/opensearch/ml/memory/index/ConversationMetaIndex.java
Outdated
Show resolved
Hide resolved
ylwu-amzn
reviewed
Sep 13, 2023
memory/src/main/java/org/opensearch/ml/memory/index/OpenSearchConversationalMemoryHandler.java
Outdated
Show resolved
Hide resolved
dhrubo-os
reviewed
Sep 13, 2023
memory/src/main/java/org/opensearch/ml/memory/index/OpenSearchConversationalMemoryHandler.java
Outdated
Show resolved
Hide resolved
memory/src/main/java/org/opensearch/ml/memory/index/ConversationMetaIndex.java
Outdated
Show resolved
Hide resolved
memory/src/main/java/org/opensearch/ml/memory/index/OpenSearchConversationalMemoryHandler.java
Outdated
Show resolved
Hide resolved
HenryL27
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
HenryL27
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
HenryL27
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
HenryL27
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
Codecov Report
@@ Coverage Diff @@
## 2.x #1334 +/- ##
============================================
- Coverage 79.40% 79.38% -0.03%
Complexity 2269 2269
============================================
Files 190 190
Lines 9167 9167
Branches 906 906
============================================
- Hits 7279 7277 -2
- Misses 1478 1479 +1
- Partials 410 411 +1
Flags with carried forward coverage won't be shown. Click here to find out more. |
dhrubo-os
approved these changes
Sep 13, 2023
ylwu-amzn
approved these changes
Sep 13, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 13, 2023
* consistent getInteractions response when security/no security Signed-off-by: HenryL27 <hmlindeman@yahoo.com> * fix deletion race condition Signed-off-by: HenryL27 <hmlindeman@yahoo.com> * cleanup Signed-off-by: HenryL27 <hmlindeman@yahoo.com> --------- Signed-off-by: HenryL27 <hmlindeman@yahoo.com> (cherry picked from commit 24a629b)
ylwu-amzn
pushed a commit
that referenced
this pull request
Sep 13, 2023
* consistent getInteractions response when security/no security Signed-off-by: HenryL27 <hmlindeman@yahoo.com> * fix deletion race condition Signed-off-by: HenryL27 <hmlindeman@yahoo.com> * cleanup Signed-off-by: HenryL27 <hmlindeman@yahoo.com> --------- Signed-off-by: HenryL27 <hmlindeman@yahoo.com> (cherry picked from commit 24a629b) Co-authored-by: HenryL27 <hmlindeman@yahoo.com>
HenryL27
added a commit
to HenryL27/ml-commons
that referenced
this pull request
Oct 3, 2023
* consistent getInteractions response when security/no security Signed-off-by: HenryL27 <hmlindeman@yahoo.com> * fix deletion race condition Signed-off-by: HenryL27 <hmlindeman@yahoo.com> * cleanup Signed-off-by: HenryL27 <hmlindeman@yahoo.com> --------- Signed-off-by: HenryL27 <hmlindeman@yahoo.com>
HenryL27
added a commit
to HenryL27/ml-commons
that referenced
this pull request
Oct 3, 2023
* consistent getInteractions response when security/no security Signed-off-by: HenryL27 <hmlindeman@yahoo.com> * fix deletion race condition Signed-off-by: HenryL27 <hmlindeman@yahoo.com> * cleanup Signed-off-by: HenryL27 <hmlindeman@yahoo.com> --------- Signed-off-by: HenryL27 <hmlindeman@yahoo.com> (cherry picked from commit 24a629b) Signed-off-by: HenryL27 <hmlindeman@yahoo.com>
HenryL27
added a commit
to HenryL27/ml-commons
that referenced
this pull request
Oct 4, 2023
* consistent getInteractions response when security/no security Signed-off-by: HenryL27 <hmlindeman@yahoo.com> * fix deletion race condition Signed-off-by: HenryL27 <hmlindeman@yahoo.com> * cleanup Signed-off-by: HenryL27 <hmlindeman@yahoo.com> --------- Signed-off-by: HenryL27 <hmlindeman@yahoo.com> (cherry picked from commit 24a629b) Signed-off-by: HenryL27 <hmlindeman@yahoo.com>
dhrubo-os
pushed a commit
that referenced
this pull request
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix issue where getInteractions returned different results in security-enabled and -disabled settings. Also fix a data race in deleteConversation that made that test flaky.
Issues Resolved
#1272
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.