Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing messaging for ILlegalArgumentException on duplicate model gr… #1294

Merged
merged 2 commits into from
Sep 7, 2023
Merged

Changing messaging for ILlegalArgumentException on duplicate model gr… #1294

merged 2 commits into from
Sep 7, 2023

Conversation

nateynateynate
Copy link
Member

…oup creation.

Description

Updating the error message shown when attempting to create a non-unique model group.

Issues Resolved

#1290

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@nateynateynate
Changing messaging for ILlegalArgumentException on duplicate model gr…
cbd71b7 
…oup creation.

Signed-off-by: Nate Boot <nateboot@amazon.com>
ylwu-amzn
ylwu-amzn previously approved these changes Sep 7, 2023
View reviewed changes
@ylwu-amzn ylwu-amzn mentioned this pull request Sep 7, 2023
Closed
@ylwu-amzn
Copy link
Collaborator

Github CI not passing

Tests with failures:
 - org.opensearch.ml.model.MLModelGroupManagerTests.test_ModelGroupNameNotUnique

Suggest run ./gradlew build locally first to verify if there is any test failure.

rbhavna
rbhavna previously approved these changes Sep 7, 2023
View reviewed changes
@rbhavna
Copy link
Collaborator

rbhavna commented Sep 7, 2023 •
edited
Loading

https://github.com/opensearch-project/ml-commons/actions/runs/6113159605/job/16592101907?pr=1294#step:5:666

Thanks for the fix @nateynateynate One of the test cases above is failing because of incorrect error message. We might have to fix it.

@nateynateynate
Copy link
Member Author

Hang on - I've already got MLModelGroupManagerTests.java up in my IntelliJ editor. Let me see if I can pull this off for you guys. :-)

@nateynateynate
Adjusting the test. ./gradlew test passes.
6346a57 
Signed-off-by: Nate Boot <nateboot@amazon.com>
@nateynateynate nateynateynate temporarily deployed to ml-commons-cicd-env September 7, 2023 18:48 — with GitHub Actions Inactive
@nateynateynate nateynateynate temporarily deployed to ml-commons-cicd-env September 7, 2023 18:48 — with GitHub Actions Inactive
@nateynateynate nateynateynate temporarily deployed to ml-commons-cicd-env September 7, 2023 18:48 — with GitHub Actions Inactive
@nateynateynate nateynateynate temporarily deployed to ml-commons-cicd-env September 7, 2023 19:47 — with GitHub Actions Inactive
@nateynateynate nateynateynate temporarily deployed to ml-commons-cicd-env September 7, 2023 19:47 — with GitHub Actions Inactive
@nateynateynate nateynateynate temporarily deployed to ml-commons-cicd-env September 7, 2023 19:47 — with GitHub Actions Inactive
@nateynateynate nateynateynate temporarily deployed to ml-commons-cicd-env September 7, 2023 20:38 — with GitHub Actions Inactive
@nateynateynate nateynateynate temporarily deployed to ml-commons-cicd-env September 7, 2023 20:38 — with GitHub Actions Inactive
@nateynateynate nateynateynate temporarily deployed to ml-commons-cicd-env September 7, 2023 20:38 — with GitHub Actions Inactive
@nateynateynate nateynateynate temporarily deployed to ml-commons-cicd-env September 7, 2023 20:38 — with GitHub Actions Inactive
@nateynateynate nateynateynate temporarily deployed to ml-commons-cicd-env September 7, 2023 20:38 — with GitHub Actions Inactive
@nateynateynate nateynateynate temporarily deployed to ml-commons-cicd-env September 7, 2023 21:03 — with GitHub Actions Inactive
@nateynateynate nateynateynate temporarily deployed to ml-commons-cicd-env September 7, 2023 21:03 — with GitHub Actions Inactive
@nateynateynate nateynateynate temporarily deployed to ml-commons-cicd-env September 7, 2023 21:03 — with GitHub Actions Inactive
@nateynateynate nateynateynate temporarily deployed to ml-commons-cicd-env September 7, 2023 21:03 — with GitHub Actions Inactive
@nateynateynate nateynateynate temporarily deployed to ml-commons-cicd-env September 7, 2023 21:03 — with GitHub Actions Inactive
@nateynateynate nateynateynate temporarily deployed to ml-commons-cicd-env September 7, 2023 21:03 — with GitHub Actions Inactive
@dhrubo-os
Copy link
Collaborator

dhrubo-os commented Sep 7, 2023 •
edited
Loading

@rbhavna do we want this in 2.10 release? If yes can you please take care of moving this to 2.10 branch before code freeze? Thanks

@saratvemulapalli
Copy link
Member

@rbhavna do we want this in 2.10 release? If yes can you please take care of moving this to 2.10 branch before code freeze? Thanks

Its definitely good customer experience. Lets merge this change.

@rbhavna rbhavna merged commit a9687fc into opensearch-project:main Sep 7, 2023
10 of 12 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 7, 2023
@nateynateynate @github-actions
Changing messaging for ILlegalArgumentException on duplicate model gr… (
6eb3ac0 
#1294)

* Changing messaging for ILlegalArgumentException on duplicate model group creation.

Signed-off-by: Nate Boot <nateboot@amazon.com>

* Adjusting the test. `./gradlew test` passes.

Signed-off-by: Nate Boot <nateboot@amazon.com>

---------

Signed-off-by: Nate Boot <nateboot@amazon.com>
(cherry picked from commit a9687fc)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Sep 7, 2023
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 7, 2023
@nateynateynate @github-actions
Changing messaging for ILlegalArgumentException on duplicate model gr… (
238d225 
#1294)

* Changing messaging for ILlegalArgumentException on duplicate model group creation.

Signed-off-by: Nate Boot <nateboot@amazon.com>

* Adjusting the test. `./gradlew test` passes.

Signed-off-by: Nate Boot <nateboot@amazon.com>

---------

Signed-off-by: Nate Boot <nateboot@amazon.com>
(cherry picked from commit a9687fc)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Sep 7, 2023
Merged
rbhavna pushed a commit that referenced this pull request Sep 8, 2023
@opensearch-trigger-bot @nateynateynate
Changing messaging for ILlegalArgumentException on duplicate model gr… (
058ec23 
#1294) (#1300)

* Changing messaging for ILlegalArgumentException on duplicate model group creation.

Signed-off-by: Nate Boot <nateboot@amazon.com>

* Adjusting the test. `./gradlew test` passes.

Signed-off-by: Nate Boot <nateboot@amazon.com>

---------

Signed-off-by: Nate Boot <nateboot@amazon.com>
(cherry picked from commit a9687fc)

Co-authored-by: Nate B <96254688+nateynateynate@users.noreply.github.com>
ylwu-amzn pushed a commit that referenced this pull request Sep 8, 2023
@nateynateynate @ylwu-amzn
Changing messaging for ILlegalArgumentException on duplicate model gr… (
2d6bfb9 
#1294)

* Changing messaging for ILlegalArgumentException on duplicate model group creation.

Signed-off-by: Nate Boot <nateboot@amazon.com>

* Adjusting the test. `./gradlew test` passes.

Signed-off-by: Nate Boot <nateboot@amazon.com>

---------

Signed-off-by: Nate Boot <nateboot@amazon.com>
(cherry picked from commit a9687fc)
Signed-off-by: Yaliang Wu <ylwu@amazon.com>
rbhavna pushed a commit that referenced this pull request Sep 8, 2023
@opensearch-trigger-bot @nateynateynate
Changing messaging for ILlegalArgumentException on duplicate model gr… (
979ac68 
#1294) (#1299)

* Changing messaging for ILlegalArgumentException on duplicate model group creation.

Signed-off-by: Nate Boot <nateboot@amazon.com>

* Adjusting the test. `./gradlew test` passes.

Signed-off-by: Nate Boot <nateboot@amazon.com>

---------

Signed-off-by: Nate Boot <nateboot@amazon.com>
(cherry picked from commit a9687fc)

Co-authored-by: Nate B <96254688+nateynateynate@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saratvemulapalli saratvemulapalli saratvemulapalli approved these changes

@dhrubo-os dhrubo-os dhrubo-os approved these changes

@rbhavna rbhavna rbhavna approved these changes

@ylwu-amzn ylwu-amzn ylwu-amzn left review comments

@b4sjoo b4sjoo Awaiting requested review from b4sjoo b4sjoo is a code owner

@jngz-es jngz-es Awaiting requested review from jngz-es jngz-es is a code owner

@model-collapse model-collapse Awaiting requested review from model-collapse model-collapse is a code owner

@wujunshen wujunshen Awaiting requested review from wujunshen

@zane-neo zane-neo Awaiting requested review from zane-neo zane-neo is a code owner

@Zhangxunmt Zhangxunmt Awaiting requested review from Zhangxunmt Zhangxunmt is a code owner

Assignees
No one assigned
Labels
backport 2.x backport 2.10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nateynateynate @ylwu-amzn @rbhavna @dhrubo-os @saratvemulapalli