Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ML Model get API #117

Merged
merged 1 commit into from
Feb 4, 2022
Merged

Conversation

Zhangxunmt
Copy link
Collaborator

Description

This change added the support for Get Model API for ml-common plugin.

Issues Resolved

Add Model-Get API.

Check List

This is the first PR for the change, which is still subject to refine.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@Zhangxunmt Zhangxunmt requested a review from a team January 11, 2022 18:29
@Zhangxunmt Zhangxunmt changed the title add mode get API add Model get API [In progress] Jan 11, 2022
@Zhangxunmt Zhangxunmt force-pushed the develop1.3 branch 2 times, most recently from 4b31f7d to 4395514 Compare January 29, 2022 23:51
@Zhangxunmt Zhangxunmt changed the title add Model get API [In progress] add ML Model get API [In progress] Jan 30, 2022
@Zhangxunmt Zhangxunmt force-pushed the develop1.3 branch 2 times, most recently from 7c45ab5 to 7979c0f Compare February 2, 2022 22:48
Signed-off-by: Xun Zhang <xunzh@amazon.com>
@ylwu-amzn
Copy link
Collaborator

We'd better put the revision in a new commit after the first round of review, so reviewers can just check the new changes easily.

Copy link
Collaborator

@ylwu-amzn ylwu-amzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the change!

@Zhangxunmt Zhangxunmt merged commit 9b56d32 into opensearch-project:main Feb 4, 2022
@ylwu-amzn ylwu-amzn mentioned this pull request Feb 8, 2022
5 tasks
@ylwu-amzn ylwu-amzn mentioned this pull request Mar 9, 2022
3 tasks
@ylwu-amzn ylwu-amzn changed the title add ML Model get API [In progress] add ML Model get API Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants